Bug 311567 – app-office/texmaker should use qt4-r2.eclass

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Ben de Groot (RETIRED) 2010-03-27 01:20:55 UTC]

app-office/texmaker is currently using the deprecated qt4.eclass and should therefore be migrated to qt4-r2.eclass. I'll attach a patch. I did some extra cleanup, but of course you're free to discard that.

[Comment 1 Ben de Groot (RETIRED) 2010-03-27 01:21:49 UTC]

Created attachment 225405 [details, diff]
texmaker-1.99.ebuild.diff

[Comment 2 Alexis Ballier 2010-03-27 12:58:51 UTC]

feel free to commit, except:

-if [ ${MINOR_2} -eq "0" ] ; then
+if [[ ${MINOR_2} -eq "0" ]] ; then

unless you have arguments for introducing a bashism

-	>=x11-libs/qt-gui-4.5.1:4
-	>=x11-libs/qt-core-4.5.1:4
+	x11-libs/qt-core:4
+	x11-libs/qt-gui:4

wtf? thats not "cleanup" thats borkage :p

[Comment 3 Ben de Groot (RETIRED) 2010-03-27 13:27:51 UTC]

(In reply to comment #2)
> +if [[ ${MINOR_2} -eq "0" ]] ; then
> 
> unless you have arguments for introducing a bashism

[[ is always better than [ except if you need posix compatibility, but
ebuilds are written in bash anyway, so there is no good reason not to use
the safer [[ test.

> +       x11-libs/qt-core:4
> +       x11-libs/qt-gui:4
> 
> wtf? thats not "cleanup" thats borkage :p

There is no lower version than 4.5.3 in the tree anymore and there hasn't been for quite a while. And as they have known security bugs, they won't return to the tree anyway. So I see no reason to specify the version here. It's simply superfluous, altho it doesn't hurt.

[Comment 4 Alexis Ballier 2010-03-27 14:39:29 UTC]

(In reply to comment #3)
> (In reply to comment #2)
> > +if [[ ${MINOR_2} -eq "0" ]] ; then
> > 
> > unless you have arguments for introducing a bashism
> 
> [[ is always better than [ except if you need posix compatibility, but
> ebuilds are written in bash anyway, so there is no good reason not to use
> the safer [[ test.

yes but here it changes nothing and adds 2 bytes
if something had to change that'd be quotes around ${MINOR_2} but we control what's in this variable; since its in global scope I indeed prefer posix compatibility


> 
> > +       x11-libs/qt-core:4
> > +       x11-libs/qt-gui:4
> > 
> > wtf? thats not "cleanup" thats borkage :p
> 
> There is no lower version than 4.5.3 in the tree anymore and there hasn't been
> for quite a while. And as they have known security bugs, they won't return to
> the tree anyway. So I see no reason to specify the version here. It's simply
> superfluous, altho it doesn't hurt.
> 

its not superfluous; think about a box not updated for a couple of years

[Comment 5 Alexis Ballier 2010-10-30 21:19:30 UTC]

this was actually done when bumped to 2.0