Bug 310993

Summary:	x11-drivers/ati-drivers miss the qt-gui deps for amdcccle
Product:	Gentoo Linux	Reporter:	Enrico Tagliavini <enrico.tagliavini>
Component:	[OLD] Unspecified	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch to add the qt-gui depend and makes the amdcccle optional another version of the patch patch to add the qt-gui depend and makes the amdcccle optional another version of the patch patch to add the qt-gui depend and makes the amdcccle optional

Description Enrico Tagliavini 2010-03-23 22:16:12 UTC

x11-drivers/ati-drivers provides the qt4 utility called amdcccle to configure the driver. The current ebuild miss the qt-gui RDEPEND. I've done a patch that makes the qt-gui dep optional, and if enabled (via qt4 USE flag) it install the amdcccle utility. If this will be accepted i raccomend to make a custom qt4 USE description in the metadata.xml file to point out that this USE flag enable the installation of that utility.

Reproducible: Always

Steps to Reproduce:

Comment 1 Enrico Tagliavini 2010-03-23 22:18:16 UTC

Created attachment 224953 [details, diff]
patch to add the qt-gui depend and makes the amdcccle optional

This patch is designed for the ati-drivers-10.2 ebuild, but with some luck it should apply to other versions too.

be aware i didn't tested this atm, i will test it as soon as possible, use at your own risk :)

Comment 2 Enrico Tagliavini 2010-03-23 22:50:35 UTC

For what is worth i've tested this patch and it works

Comment 3 Enrico Tagliavini 2010-03-23 23:04:35 UTC

Created attachment 224985 [details, diff]
another version of the patch

This version uses a custom amdcccle USE flag instead of the qt4 of the previous patch. Nothing else different, i provide it just in case you prefer this way.

Comment 4 Luca Barbato gentoo-dev

2010-03-23 23:16:01 UTC

I pushed a slightly different patch (I'm removing amdcccle in src_prepare), I'm a bit tired so please doublecheck it.

Comment 5 Enrico Tagliavini 2010-03-23 23:29:48 UTC

Created attachment 225007 [details, diff]
patch to add the qt-gui depend and makes the amdcccle optional

I posted the wrong patch, this contains also the qt-core deps for the amdcccle utility

Comment 6 Enrico Tagliavini 2010-03-23 23:30:33 UTC

Created attachment 225009 [details, diff]
another version of the patch

and this is the counterpart always with only the USE name change

Comment 7 Enrico Tagliavini 2010-03-23 23:35:40 UTC

(In reply to comment #4)
> I pushed a slightly different patch (I'm removing amdcccle in src_prepare), I'm
> a bit tired so please doublecheck it.
> 

Oh you are right it is better there, it more clean. Sorry but sometimes i forget the good ebuild policy eheheh

Comment 8 Enrico Tagliavini 2010-03-24 20:14:15 UTC

Created attachment 225147 [details, diff]
patch to add the qt-gui depend and makes the amdcccle optional

Updated version including luca's mod

Comment 9 Enrico Tagliavini 2010-05-27 09:09:30 UTC

It is in tree from some time, so i guess this can be resolved as fixed. Thank you very much. Cheers