Summary: | dev-libs/nss ebuild disregards CFLAGS in bitiness test | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Nathan Phillip Brink (binki) (RETIRED) <binki> |
Component: | [OLD] Library | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 306835 | ||
Attachments: | nss-3.12.5-r1.ebuild-CFLAGS-looknice.patch |
Description
Nathan Phillip Brink (binki) (RETIRED)
2010-03-18 23:37:20 UTC
Created attachment 224201 [details]
nss-3.12.5-r1.ebuild-CFLAGS-looknice.patch
I couldn't help but notice that the ebuild also does some weird sed expression stuff with pkg-config which can be avoided using pkg-config's --variable functionaliy ;-)
The sed expressions are correct if you look at the code. Far as cflags are concerned will look at that later tonight. The check is fine as is. The multilib profile should be setting its compiler before the check is made to determine the arch being built for. The check is fine as is. The multilib profile should be setting its compiler before the check is made to determine the arch being built for. (In reply to comment #4) > The check is fine as is. The multilib profile should be setting its compiler > before the check is made to determine the arch being built for. Multilib support in GCC is not the same thing as crosscompiling. In fact, crossdev and portage-multilib are incompatible and will remain so for a while AFAIK. Bitiness can be affected by CFLAGS. See gcc's manpage for the -m32 and -m64 flags. I went ahead and added cflags which I still say is not needed. Will find in -r1 which uses official release media for 12.6 |