Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 309129

Summary: net-misc/dhcp-4.1.0: dhcrelay misconfigured pid file path
Product: Gentoo Linux Reporter: Milan Dadok <dadok>
Component: New packagesAssignee: Gentoo's Team for Core System packages <base-system>
Status: VERIFIED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Milan Dadok 2010-03-12 12:15:42 UTC
In ebuild is configure option
--with-relay-pid-file=/var/run/dhcp/dhcrelay.pid
but in init.d script is different path
this patch helps (not tested on dhcp v3)
--- dhcrelay.init.orig  2010-03-12 12:55:16.000000000 +0100
+++ dhcrelay.init       2010-03-12 12:55:41.000000000 +0100
@@ -27,6 +27,6 @@

 stop() {
        ebegin "Stopping dhcrelay"
-       start-stop-daemon --stop --pidfile /var/run/dhcrelay.pid
+       start-stop-daemon --stop --pidfile /var/run/dhcp/dhcrelay.pid
        eend $?
 }


Reproducible: Always

Steps to Reproduce:
1. /etc/init.d/dhcrelay restart

Actual Results:  
 * Stopping dhcrelay ...  [ ok ]
 * Starting dhcrelay ...
/usr/sbin/dhcrelay already running. [ !! ]

Expected Results:  
 * Stopping dhcrelay ... [ ok ]
 * Starting dhcrelay ... [ ok ]
Comment 1 SpanKY gentoo-dev 2011-03-05 23:54:53 UTC
should be fixed with dhcp-4.2.1
Comment 2 Milan Dadok 2011-12-04 08:09:35 UTC
There is new typo in dhcrelay.pid path, starting from dhcp-4.2.2-r1.ebuild, there is dhcprelay.pid instead of correct dhcrelay.pid, same typo in dhcrelay6.pid

dhcp-4.2.1_p1.ebuild:           --with-relay-pid-file=/var/run/dhcp/dhcrelay.pid \
dhcp-4.2.2.ebuild:              --with-relay-pid-file=/var/run/dhcp/dhcrelay.pid \
dhcp-4.2.2-r1.ebuild:   #define _PATH_DHCRELAY_PID   "${r}/dhcprelay.pid"
dhcp-4.2.2-r2.ebuild:   #define _PATH_DHCRELAY_PID   "${r}/dhcprelay.pid"
files/dhcrelay.init2:   start-stop-daemon --stop --pidfile /var/run/dhcp/dhcrelay.pid

this patch helps
--- dhcp-4.2.2-r2.org.ebuild    2011-12-04 09:02:06.000000000 +0100
+++ dhcp-4.2.2-r2.ebuild        2011-12-04 09:02:26.000000000 +0100
@@ -143,2 +143,2 @@
-       #define _PATH_DHCRELAY_PID   "${r}/dhcprelay.pid"
-       #define _PATH_DHCRELAY6_PID  "${r}/dhcprelay6.pid"
+       #define _PATH_DHCRELAY_PID   "${r}/dhcrelay.pid"
+       #define _PATH_DHCRELAY6_PID  "${r}/dhcrelay6.pid"
Comment 3 SpanKY gentoo-dev 2011-12-04 22:44:55 UTC
for future reference, new issues should be reported in new bugs.  and please don't muck with the status field.

bug should be fixed with dhcp-4.2.2-r3.