| Summary: | media-video/mplayer ebuild fixes and enhancements | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andrew Savchenko <bircoph> |
| Component: | New packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | Reimar.Doeffinger, sping |
| Priority: | High | Keywords: | Inclusion |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 305509 | ||
| Attachments: |
return back opencore-amr support
bs2b dep cdparanoia dep fix subs without X docs enhancement |
||
|
Description
Andrew Savchenko
2010-01-02 22:18:39 UTC
Created attachment 214956 [details, diff]
return back opencore-amr support
opencore-amr support was dropped after mplayer-1.0_rc4_p20091026-r1.ebuild.
I can't understand why: license is Apache 2.0, so it should induce no problems, this is not the same trouble as with amrnb/amrwb. Maybe just missed during update?
Created attachment 214957 [details, diff]
bs2b dep
Dependency on libbs2b was missed.
Created attachment 214958 [details, diff]
cdparanoia dep fix
If both cdio and cdparanoia are specified, cdio will be used. Thus depend on cdparanoia only if cdio is not requested.
Created attachment 214960 [details, diff]
subs without X
It is possible to use subtitle rendering in mencoder even if X server is not installed (I sometimes use this on my home X-less server to convert video). So ass and truetype should not relate to the "X" use flag.
Created attachment 214961 [details, diff]
docs enhancement
1) This patch generates docs for only those languages which are present in $LINGUAS. It was proposed earlier, but is not used for some reason, at least now. So, this is try #2.
2) In current ebuild html docs will be installed in the tech/mirrors/ because of docinto directive below html docs installation. This patch also fixes this and installes html docs in the html dir.
Apache 2.0 license is not compatible with GPLv2, only with GPLv3. I do not know if all of MPlayer can be relicensed as GPLv3, I actually doubt it. Which means that the issue to my knownledge is basically unchanged: compiling your own binary with AMR support is ok, distributing the resulting binary is not though. Thanks for submitting your mplayer enhancements, assigning to maintainers. (In reply to comment #6) > Apache 2.0 license is not compatible with GPLv2, only with GPLv3. > I do not know if all of MPlayer can be relicensed as GPLv3, I actually doubt > it. > Which means that the issue to my knownledge is basically unchanged: compiling > your own binary with AMR support is ok, distributing the resulting binary is > not though. Well, if we disable opencore-amr support for bindist, then everything should be ok: binary with AMR will not be distributed, sources will be build on local systems. Maybe a warning should be issued as well to aware from binary redistribution if AMR was included. I agree that toggling it with bindist should be ok, I just wanted to make sure possible issues aren't missed.
And (slightly off-topic) I'd also be grateful if someone could look into these
filter-flags -fPIC -fPIE
append-flags -D__STDC_LIMIT_MACROS
is-flag -O? || append-flags -O2
and report proper bugs upstream (or just to me) if there are still issues (except slower speed), and if not get rid of them.
(In reply to comment #2) > Created an attachment (id=214957) [details] > bs2b dep > > Dependency on libbs2b was missed. FYI this has been fixed for bug #287993 by now. (In reply to comment #4) > Created an attachment (id=214960) [details] > subs without X > > It is possible to use subtitle rendering in mencoder even if X server is not > installed (I sometimes use this on my home X-less server to convert video). So > ass and truetype should not relate to the "X" use flag. > applied this one to -9999 (In reply to comment #8) > (In reply to comment #6) > > Apache 2.0 license is not compatible with GPLv2, only with GPLv3. > > I do not know if all of MPlayer can be relicensed as GPLv3, I actually doubt > > it. > > Which means that the issue to my knownledge is basically unchanged: compiling > > your own binary with AMR support is ok, distributing the resulting binary is > > not though. > > Well, if we disable opencore-amr support for bindist, then everything should be > ok: binary with AMR will not be distributed, sources will be build on local > systems. Maybe a warning should be issued as well to aware from binary > redistribution if AMR was included. > -9999 now disables amr support with bindist useflag set Comment on attachment 214956 [details, diff]
return back opencore-amr support
patch merged -> obsolete
Comment on attachment 214960 [details, diff]
subs without X
patch merged -> obsolete
Comment on attachment 214957 [details, diff]
bs2b dep
patch merged -> obsolete
(In reply to comment #3) > Created an attachment (id=214958) [details] > cdparanoia dep fix > > If both cdio and cdparanoia are specified, cdio will be used. Thus depend on > cdparanoia only if cdio is not requested. > applied in -9999 Comment on attachment 214958 [details, diff]
cdparanoia dep fix
patch merged -> obsolete
(In reply to comment #5) > Created an attachment (id=214961) [details] > docs enhancement > > 1) This patch generates docs for only those languages which are present in > $LINGUAS. It was proposed earlier, but is not used for some reason, at least > now. So, this is try #2. > > 2) In current ebuild html docs will be installed in the tech/mirrors/ because > of docinto directive below html docs installation. This patch also fixes this > and installes html docs in the html dir. > merged a (imho) simplified version of this patch in -9999 Comment on attachment 214961 [details, diff]
docs enhancement
patch merged -> obsolete
(In reply to comment #9) > And (slightly off-topic) I'd also be grateful if someone could look into these > filter-flags -fPIC -fPIE most likely because of poor registers on x86; this is filtered only on x86 now > append-flags -D__STDC_LIMIT_MACROS bug #127901, seems unneeded, dropped > is-flag -O? || append-flags -O2 just a guess: doesn't mplayer fail at -O0 ? All changes should be merged now, everyone happy, closing bug; thanks for the improvements! |