Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 29852

Summary: Out of date xpad ebuilds need to use nls, update dependencies, and install correct docs
Product: Gentoo Linux Reporter: Michael Terry <mterry>
Component: New packagesAssignee: Desktop Misc. Team <desktop-misc>
Status: RESOLVED FIXED    
Severity: enhancement    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Patch for xpad-1.11.ebuild
Updated patch for 1.11
Patch for 1.10.1
Patch for 1.4

Description Michael Terry 2003-09-28 18:40:01 UTC
I noticed that the xpad (x11-misc/xpad) ebuilds could use some attention.  In
particular, the dependencies are not as explicit as they could be, the nls use
flag was being ignored, and the dodoc line was incorrect.

I have fixed these problems and have tried to use current ebuild policy (e.g.
=x11-libs/gtk+-2* and einstall).

I am about to attach a patch for xpad-1.11.  Patches for the remaining ebuilds
(1.4 and 1.10.1) will be forthcoming.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Michael Terry 2003-09-28 18:40:46 UTC
Created attachment 18446 [details, diff]
Patch for xpad-1.11.ebuild
Comment 2 Michael Terry 2003-09-28 19:45:25 UTC
Created attachment 18447 [details, diff]
Updated patch for 1.11

I updated the SRC_URI variable to point to the bz2 instead of the gz.
Comment 3 Michael Terry 2003-09-28 19:47:46 UTC
Created attachment 18448 [details, diff]
Patch for 1.10.1

This is a tad different than the patch for 1.11.  First, the gettext DEPEND
was
moved to RDEPEND, since 1.10.1 included an internal gettext.

Also, the dodoc line has been changed.
Comment 4 Michael Terry 2003-09-28 19:50:37 UTC
Created attachment 18449 [details, diff]
Patch for 1.4

Real simple patch, since 1.4 is much less advanced than 1.10.1 or 1.11.

Basically, add IUSE variable, update DEPEND to use glibc and have nicer syntax
for gtk2, and use einstall.  Note that x11 and gettext aren't dependencies
--
this is because 1.4 does not need them during compile and doesn't use gettext.
Comment 5 Brandon Hale (RETIRED) gentoo-dev 2004-01-24 07:54:26 UTC
Removed the old versions from cvs and added some of your cleanups.
Thanks!
--tseng
Comment 6 Michael Terry 2004-01-24 21:04:05 UTC
Dah!  You removed all but 1.4, the oldest and worst xpad ebuild.

Please reinstate at least version 1.11, which was working well on stable.
Comment 7 Brandon Hale (RETIRED) gentoo-dev 2004-01-25 06:31:22 UTC
Fixed that up, 1.4 looked biggest in my bug squashing yesterday =/
Also marked 1.13 stable on x86, its been around a long time w/o open issues, it seems. Thanks Michael.
Comment 8 Brandon Hale (RETIRED) gentoo-dev 2004-01-25 08:13:10 UTC
Oh hey Mike, try building this w/ USE="-nls" 
...
Totally dies on me w/ LC_ALL undefined.
I might have to remove your use_enable nls stuff =/
Comment 9 Michael Terry 2004-01-25 08:47:27 UTC
Looks like a problem upstream.  Please remove the use_enable stuff from the ebuild.  Thank you.
Comment 10 Brandon Hale (RETIRED) gentoo-dev 2004-01-25 09:09:02 UTC
Closing, I hope.