Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 297326

Summary: media-libs/iulib ebuild autodepends on ffmpeg/sdl
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: New packagesAssignee: SpanKY <vapier>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: First version of my ebuild
Patch to build shared libs
Patch to fix missing '-I' CPPFLAGS
CPPFLAGS fix improved to fix tests too
Updated shared lib building patch
Fix automagic depends
Fix compilation with ffmpeg
Fix linking with ffmpeg
Updated ebuild
Build shared libs

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 20:34:57 UTC
Current portage ebuild for iulib has many issues including:
- missing dependencies,
- ignorance of USE flags,
- ignorance of configure results,
- building static library only.

This makes it almost useless. I'm providing alternate ebuild, using autotools as supported by upstream and providing necessary fixes for it.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 20:35:49 UTC
Created attachment 213322 [details]
First version of my ebuild
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 20:36:08 UTC
Created attachment 213324 [details, diff]
Patch to build shared libs
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 20:36:27 UTC
Created attachment 213325 [details, diff]
Patch to fix missing '-I' CPPFLAGS
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 20:58:57 UTC
Created attachment 213327 [details, diff]
CPPFLAGS fix improved to fix tests too
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 20:59:33 UTC
Created attachment 213329 [details, diff]
Updated shared lib building patch
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 21:35:15 UTC
Created attachment 213339 [details, diff]
Fix automagic depends

This one adds --with{,out}-{vidio,v4l2} options to configure, and additionally fixes ffmpeg header paths in configure.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 21:58:12 UTC
Created attachment 213347 [details, diff]
Fix compilation with ffmpeg
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 21:58:26 UTC
Created attachment 213348 [details, diff]
Fix linking with ffmpeg
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-17 21:58:46 UTC
Created attachment 213350 [details]
Updated ebuild
Comment 10 Rafał Mużyło 2009-12-18 10:27:30 UTC
If all of this actually works - good job.
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-18 16:21:18 UTC
Created attachment 213396 [details, diff]
Build shared libs

Fixed shared lib patch so that it won't break --enable-static.
Comment 12 SpanKY gentoo-dev 2009-12-18 16:44:29 UTC
upstream switched to scons.  post your patches to the upstream tracker:
http://code.google.com/p/iulib/issues/list
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-18 17:00:44 UTC
(In reply to comment #12)
> upstream switched to scons.  post your patches to the upstream tracker:
> http://code.google.com/p/iulib/issues/list

Then they forgot to finish it first. IMO there's no sense to use it right now as it requires more effort to build sources correctly.

Should I prepare patches for SCons then?

And the changed summary does mention only one issue which is not as important as other ones.
Comment 14 SpanKY gentoo-dev 2009-12-18 18:07:47 UTC
if by "forgot" you mean they didnt `svn rm configure*` before the 0.4 release, then that is correct.  but in the end, irrelevant seeing as how the latest svn has punted the files.

i wish upstream could be convinced to stop using a POS system like scons, but since that probably isnt going to happen, patches need to be written for it.

the autodeps are the only real issues.  the rest are noise.  and no, i'm not going to add a patch for a shared library without upstream signing on first.  the ease of making one is irrelevant compared to the real issue (ABI).
Comment 15 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-12-18 18:16:17 UTC
(In reply to comment #14)
> if by "forgot" you mean they didnt `svn rm configure*` before the 0.4 release,
> then that is correct.  but in the end, irrelevant seeing as how the latest svn
> has punted the files.

I rather meant mentioning it in INSTALL, which even in latest rev suggests using autotools outside ubuntu.

> i wish upstream could be convinced to stop using a POS system like scons, but
> since that probably isnt going to happen, patches need to be written for it.

Latest rev seems to fix most of the issues. I agree that with new releases we should indeed use scons, but for 0.4 release I think it's better to simply fix few issues in autotools and use it than to pull back all changes in SConstruct.
Comment 16 SpanKY gentoo-dev 2010-03-20 21:23:25 UTC
ffmpeg/v4l2 is always disabled in current scons, so i just tweaked the sdl part

http://sources.gentoo.org/media-libs/iulib/iulib-0.4.ebuild?r1=1.2&r2=1.3