Bug 29309 - lcms-1.11 ebuild contains redundant code
Bug#: 29309 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: lanius@gentoo.org Reported By: brandy@gentoo.org
Component: Library
URL: 
Summary: lcms-1.11 ebuild contains redundant code
Keywords:  
Status Whiteboard: 
Opened: 2003-09-21 21:39 0000
Description:   Opened: 2003-09-21 21:39 0000
The lcms-1.11 ebuild contains a redundant block of code that seemsto be 
a throwback to the old lcms-1.09 ebuild where there was no configure 
script and the tiff and jpeg utils had to be explicitely built: 
 
 
	src_install() { 
		..... 
		( use tiff && use jpeg ) && ( \ 
		make \ 
			DESTDIR=${D} \ 
			utils || die 
		) 
		..... 
	} 
 
 
In fact the configure-genreated Makefile in lcms-1.11 doesn't contain 
the target utils and when emerging the following error is encountered: 
 
 
	make: *** No rule to make target `utils'.  Stop. 
 
	!!! ERROR: media-libs/lcms-1.11 failed. 
	!!! Function src_install, Line 38, Exitcode 2 
	!!! (no error message) 
 
 
(Since the die statement is nested within parentheses the compile 
doesn't stop; apart from this annoying error message, nothing untoward 
happens.)  
 
It also might be worthwhile making tiff and jpeg optional dependencies 
of lcms since they don't need to be installed if we don't want the tiff 
and jpeg utils.

------- Comment #1 From Heinrich Wendel (RETIRED) 2003-09-22 07:11:51 0000 -------
thx, fixed :)