Summary: | groff fails to produce output with japanese patch in various ebuilds | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andrew Savchenko <bircoph> |
Component: | [OLD] Library | Assignee: | CJK Team <cjk> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dkarasik, flameeyes, gentoo-bugzilla, gentoo, HAJEK1, hiyuh.root, joost.ruis, naota, nbowler, wilburpan, x11 |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
bulid.log
environment patch for the japanese patch patch for the ebuild to apply the above patch and the japanese patch adds doc USE flag, disabling which works around groff failing on libX11 specification docs |
Description
Andrew Savchenko
2009-10-22 07:10:20 UTC
Created attachment 207890 [details]
bulid.log
Created attachment 207891 [details]
environment
This is caused by the japanese patch to groff. Building groff with -linguas_ja allows the emerge to succeed. *** Bug 290719 has been marked as a duplicate of this bug. *** linguas_jp useflag masked. Please base guys review and remove the support if needed or fix and unmask. we dont handle CJKV issues The useflag is called linguas_ja, not linguas_jp. Created attachment 208693 [details, diff]
patch for the japanese patch
Created attachment 208695 [details, diff]
patch for the ebuild to apply the above patch and the japanese patch
First, I found that the Japanese patch didn't affected the C++ code. Apply the Japanese patch, "./configure --enable-japanese" and check "src/include/config.h". There wouldn't be "#define NIPPON" line to enable Japanese patch features. This caused the error "/usr/share/groff/1.20.1/font/devps/M:5: error: I didn't seem to find any characters". We need to rebuild "src/include/config.hin" by calling "eautoheader". Then, the Japanese patch is so old that compile fails with some errors. I needed the above patch to build. I've confirmed that the above patch fixed all above errors. I was able to see Japanese man pages with patch applied package. Is maintaining this patch really the best option? It seems to originate from debian and they have moved on to a newer multi-byte patch, and then dropped even that saying: * Dropped multibyte patch. CJK is partially supported by way of Unicode input, but widths are wrong and proper line breaking is not implemented; this is planned to be added by way of "character classes". However, I can't justify holding new groff code out of Debian any longer when CJK manual pages can more or less be read with the new release. (In reply to comment #11) iirc, that patch comes from momonga. i think that non-patched broken unicode support that produces wrong width and improper line breaking is simply useless for cjk peeps. i know incomplete cjk patch often annoy non-cjk peeps, and im feel so sorry about that. but please calm down, maintain l10n, and go for i18n. kthx *** Bug 290844 has been marked as a duplicate of this bug. *** I agree that we should strive for better CJK. I didn't mean to imply that we should drop the patch, more asking whether the multibyte patch that succeeded it in Debian is better than the original? Created attachment 208876 [details, diff]
adds doc USE flag, disabling which works around groff failing on libX11 specification docs
Current x11-libs/libX11-1.3.2.ebuild fails due to a groff problem when building specs docs. With this patch specs docs are built only if the doc USE flag is enabled, allowing to bypass the groff issue until it is solved.
(In reply to comment #14) > I agree that we should strive for better CJK. I didn't mean to imply that we > should drop the patch, more asking whether the multibyte patch that succeeded > it in Debian is better than the original? > Debian stable keeps old version (groff-1.18.1) for japanese issue. It contains japanese patch but it couldn't apply to latest groff. The attached patch is better way I think. Debian testing uses groff-1.20.1-6 and it has no japanese patch so 'groff -Tnippon -mandocj' doesn't work. btw, sys-apps/man-db can show japanese manpages but it had not supported Japanese hyphenation yet. I commit groff-1.20.1-r2.ebuild now. FYI from my test of groff-1.20.1-r2 w/ linguas_ja, * it shows correct japanese man page. * failure libX11 w/ doc is gone. profiles/base/package.use.mask: -sys-apps/groff linguas_ja +<sys-apps/groff-1.20.1-r2 linguas_ja |