Bug 289314 – sys-apps/openrc: Set ABI dependent vars at the beginning of each src_* function needing them

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Thomas Sachau 2009-10-16 13:06:58 UTC]

Current version of openrc fails to detect and build the 32bit version with multilib-portage because of libdir detection in pkg_setup. In addition, mv in src_install fails to overwrite dirs, which have content. The following attached patch fixes both issues.

[Comment 1 Thomas Sachau 2009-10-16 13:19:31 UTC]

Created attachment 207309 [details]
patch for openrc-0.5.1-r1 to work with multilib-portage

[Comment 2 SpanKY 2009-10-16 14:41:29 UTC]

are you sure your last change is correct ?  i cant imagine `rm -f` working on a directory.

the 3rd hunk is also incomplete.  you've made the [[ -z ${MAKE_ARGS} ]] check obsolete.

[Comment 3 Thomas Sachau 2009-10-16 14:47:59 UTC]

Created attachment 207316 [details]
patch against openrc-0.5.1-r1

updated patch.

What do you mean by "the 3rd hunk is also incomplete."?

[Comment 4 SpanKY 2009-10-16 15:07:02 UTC]

i explained what was wrong with the 3rd hunk, and the new patch fixes it

i dont think the branding change is correct.  ${brand} is declared local.  so keep BRANDING setting in makeargs().

you need a new line above pkg_setup()

now that i think about it again, i think you need `cp -PR` and not `cp -r`

[Comment 5 Thomas Sachau 2009-10-16 15:49:07 UTC]

Created attachment 207320 [details, diff]
patch against openrc-0.5.1-r1

updated patch as suggested

[Comment 6 SpanKY 2009-10-16 21:34:24 UTC]

i dont see anything wrong with that, so assuming you've tested it, feel free to add to the 0.5.1-r1 and 9999 ebuilds.

[Comment 7 SpanKY 2009-10-16 22:57:07 UTC]

erm, didnt mean to close yet

[Comment 8 Thomas Sachau 2009-10-18 18:15:53 UTC]

(In reply to comment #6)
> i dont see anything wrong with that, so assuming you've tested it, feel free to
> add to the 0.5.1-r1 and 9999 ebuilds.
> 

committed