Bug 286010

Summary:	[gnome-overlay] gnome-extra/gnome-power-manager: does not compile with USE=-hal
Product:	Gentoo Linux	Reporter:	Florian Scandella <flo>
Component:	[OLD] GNOME	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	minor	CC:	kanelxake
Priority:	Low
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Florian Scandella 2009-09-22 19:19:43 UTC

if hal is disabled the cpufreq backport of gnome-overlay is causing an compile error (missing hal).

the patch should be applied conditionally (if at all, gnome-applets has an cpufreq applet).

Reproducible: Always

Comment 1 Romain Perier (RETIRED) gentoo-dev

2009-09-22 20:54:37 UTC

Theorically the cleaner way to handle this issue would be use the conditionnal compilation (AC_DEFINE + AM_CONDITIONNAL + macro-constants) including the cpufreq capplet only when hal support is enabled (from sources using autotools).

Then if USE=-hal if given, we could display a warning from pkg_setup() using ewarn.

We avoid to apply patches conditionally from ebuilds for some technical reasons.

- This alternative would fix the issue .
- And would give the opportunity to disable the cpufreq capplet (for example when a user prefers to use cpufreq applet from gnome-panel)

Comment 2 Romain Perier (RETIRED) gentoo-dev

2009-10-10 14:24:29 UTC

Bump to 2.28.0 and bug fixed,
resync your overlay :)

Comment 3 Florian Scandella 2009-10-11 00:10:26 UTC

confirmed working, thx