Summary: | subversion.eclass: ESVN_WC_REVISION references revision before "svn up" instead of the one after | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Andre <andre> |
Component: | Eclasses | Assignee: | Akinori Hattori <hattya> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | arfrever.fta, fuzzyray, leho, mgorny |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://thread.gmane.org/gmane.linux.gentoo.devel/86748 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | example ebuild where you can see the bug |
Description
Andre
2009-08-23 19:27:01 UTC
Created attachment 202075 [details]
example ebuild where you can see the bug
You can run subversion_wc_info again... I ran into the same problem with the gentoolkit-9999 ebuild. However, when I read the eclass source code, it looked like a deliberate decison to not update the variable until the pkg_preinst phase. For my purposes, I was able to do what I wanted in that phase. It is not clear to me, if that is acceptable in your example ebuild. Changing ESVN_WC_REVISION would break existing ebuilds. We can introduce new variables e.g ESVN_PREVIOUS_WC_REVISION and ESVN_CURRENT_WC_REVISION. this is a problem in media-tv/xbmc-9999 too. *** Bug 294135 has been marked as a duplicate of this bug. *** did anyone ever do anything about this? Since xbmc moved to git I personally have no interest anymore. I'm now having to work-around this in sys-devel/llvm. @Arfrever: which ebuilds exactly depend on this kind of information? Grepping the tree only shows 6 ebuilds that are actually saying 'eclass is broken' and calling subversion_wc_info to get the right revision. Plus two that are actually using the 'previous' revision for a version number which looks like a bug to me. To sum up, there's no in-tree ebuild which uses this kind of useless, pointless and *confusing* functionality. And there's no reason to keep this broken in the name of backwards compatibility with non-existent ebuilds. Due to no reply from maintainer, I've sent the necessary patch to gentoo-dev for review. If I get no negative replies, I'll commit it in a week starting from now. + 27 Jul 2013; Michał Górny <mgorny@gentoo.org> subversion.eclass: + Export working copy information after the update rather than in + pkg_preinst(). This makes it possible for ebuild to reference e.g. + ESVN_WC_REVISION properly. Bug #282486. + |