| Summary: | [PATCH] gnome-base/gdm: wrong DESKTOP_SESSION set under corner case circumstances | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Fabio Erculiani (RETIRED) <lxnay> |
| Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | fix DESKTOP_SESSION env variable setup | ||
Created attachment 201213 [details, diff]
fix DESKTOP_SESSION env variable setup
ah the vicious bug, thanks for finding this out. Could you also test/check that gdm-2.26 code is safe wrt this issue ? You're welcome :) Looking at gdm 2.26.1 source code, code has been completely rewritten and it doesn't seem to have issues here (just tested) +*gdm-2.20.10-r2 (24 Aug 2009) + + 24 Aug 2009; Romain Perier <mrpouet@gentoo.org> + -gdm-2.20.10-r1.ebuild, +gdm-2.20.10-r2.ebuild, + +files/gdm-2.20.10-desktop-session-dmrc-autologin.patch: + Fix bug #281442, wrong DESKTOP_SESSION set if ${HOME}/.dmrc is empty and + autologin enabled. Thanks to Fabio Erculiani <lxnay@sabayonlinux.org> for + this work. Clean up old revision. Fixed into the main tree with a revision bump. Thanks for you work and for reporting ;) |
When ${HOME}/.dmrc is not found or does not contain any relevant data AND autologin is enabled, gdm fails to set DESKTOP_SESSION, not stripping ".desktop" extension to session char* variable. This is a bug in daemon/slave.c code and causes the GNOME Applications menu to not be shown when in use with new gnome-base/gnome-menus-2.26.x session ebuilds because DESKTOP_SESSION="gnome.desktop" instead of DESKTOP_SESSION="gnome" Please find a working patch attached (tested on gdm-2.20.10) Reproducible: Always Steps to Reproduce: