if the default font in xmms_osd plugin was not selected the offset and h_offset
are not correct in startup
Reproducible: Always
Steps to Reproduce:
1.change font in the config window of xmms_osd plugin + enable it
2.restart xmms
i saw there was a patch in portage for 2.2.4 xmms_osd-2.2.4-gentoo.diff
if you have a look at the source of xosd-2.2.4/src/xmms_plugin/xmms_osd.c in
void apply_config (void)
you see that the font is set after the alignment
so changing
xosd_set_pos (osd, pos);
xosd_set_align (osd, align);
if (xosd_set_font (osd, font) == -1)
{
DEBUG("invalid font %s", font);
}
in :
if (xosd_set_font (osd, font) == -1)
{
DEBUG("invalid font %s", font);
}
xosd_set_pos (osd, pos);
xosd_set_align (osd, align);
fixes the bug and we all live happy ;)
my info :
emerge info
Portage 2.0.49-r3 (mydefault-x86-1.4, gcc-3.2.3, glibc-2.3.2-r1, 2.6.
0-test4-bk3)
=================================================================
System uname: 2.6.0-test4-bk3 i686 AMD Athlon(tm) processor
ccache version 2.2 [enabled]
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-tbird -O2 -mmmx -m3dnow -fomit-frame-pointer -mfpmath=387
-funroll-loops"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config
/usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-march=athlon-tbird -O2 -mmmx -m3dnow -fomit-frame-pointer
-mfpmath=387 -funroll-loops"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs sandbox ccache buildpkg prelink autocvs"
GENTOO_MIRRORS=" http://ftp.gentoo.skynet.be/pub/gentoo/ http://ftp.easynet.
nl/mirror/gentoo/ http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ http:
//ftp.snt.utwente.nl/pub/os/linux/gentoo http://linux.rz.ruhr-uni-bochum.
de/download/gentoo-mirror/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="x86 oss avi crypt cups encode gif jpeg libg++ libwww mad mikmod mmx motif
mpeg ncurses nls pdflib png qt quicktime spell truetype xml2 xmms xv zlib
directfb alsa gdbm slang readline aalib svga java X sdl gpm tcpd pam ssl perl
python esd imlib oggvorbis opengl 3dnow dnow fbcon fbdev gtk2 php skey sse
type1
xml xosd -apm --arts --berkdb -foomaticdb --kde --gnome -gtk"
