Summary: | [GNOME/upstream] net-libs/webkit-gtk dark theme support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Priit Laes (IRC: plaes) <plaes> |
Component: | New packages | Assignee: | Markus Ullmann (RETIRED) <jokey> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | gnome |
Priority: | High | Keywords: | Inclusion |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugs.webkit.org/show_bug.cgi?id=15597 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 274449 | ||
Attachments: |
1.1.10 ebuild
dark theme patch for forms few fixes in ebuild fixed patching updated patch |
Description
Priit Laes (IRC: plaes)
2009-06-17 05:55:26 UTC
well I made an ebuild that fixed some bugs in prev. version and add more features to set. However it will need some tests with all this features enabled/disabled. And I add patch for dark themes and forms. Created attachment 194966 [details]
1.1.10 ebuild
Created attachment 194968 [details]
dark theme patch for forms
Created attachment 194974 [details]
few fixes in ebuild
@Lukas: This ebuild use EAPI="2", so your patch need to be applied from src_prepare() and not from src_unpack(), for exemple after the sed expression. can you fix it ? thanks ;) Created attachment 195171 [details]
fixed patching
ok :) I hope it is ok now :)
@Lukas: well thanks, now can open an upstream and attach your patch to it ? (open a bug on bugzilla.gnome.org, explain your fix, then attach your patch) post on bugs.webkit.org and not bugzilla.gnome.org sorry :\ Bumped into the tree, now just missing your upstream Lukas and then we can close this bug. @Priit: Thanks for your original ebuild :) Created attachment 195230 [details, diff]
updated patch
There is already opened bug in webkit bugzilla. This patch is mainly from there, I only added one more fix, and now I have removed lines what aren't necessary. I can post it there, but this is just a workaround if I understood it well, until it will be fixed by better way more. At this moment in theme changing the page must be reloaded to proper font color. But better than nothing (I mean better then write something and don't see what :)).
> There is already opened bug in webkit bugzilla. This patch is mainly from
> there, I only added one more fix, and now I have removed lines what aren't
> necessary. I can post it there, but this is just a workaround if I understood
> it well, until it will be fixed by better way more. At this moment in theme
> changing the page must be reloaded to proper font color. But better than
> nothing (I mean better then write something and don't see what :)).
>
Could you please post link to bug in webkit's bugzilla...
> Could you please post link to bug in webkit's bugzilla... > yep, https://bugs.webkit.org/show_bug.cgi?id=15597 Updating summary... Well, gnome herd is now in CC list of the upstream bug, if upstream developers are agree about this patch we will include it (depending if there is an other version bump which may be could fix this problem) i'm close this bug |