Summary: | media-tv/mythtv-0.21_p19961-r2 fails to compile with glibc-2.10 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Timothy Knoll <knollbert+gentoo> |
Component: | Current packages | Assignee: | Doug Goldstein (RETIRED) <cardoe> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra, media-tv |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 270353 | ||
Attachments: | changes strchr to (char *)strchr for gcc-4.4 |
Description
Timothy Knoll
2009-06-03 04:17:00 UTC
Created attachment 193360 [details, diff]
changes strchr to (char *)strchr for gcc-4.4
Not GCC 4.4, it's glibc 2.10, see http://blog.flameeyes.eu/2009/05/24/c-libraries-galore And the patch is wrong, it should probably change the type of the variable where the return value is stored instead of casting it away. either way works. I chose this method solely because it should work with previous gcc/glib versions Just because it is not the way you would have done it, does not mean its wrong. Does it compile -- yes. Therefore its good enough for me. I said it was the gcc because the gcc porting guide ( http://gcc.gnu.org/gcc-4.4/porting_to.html ) mentions it. Whether its the gcc or glibc, I don't know. All I know is that it needs to fixed. fixed in http://svn.mythtv.org/trac/changeset/20671 so a simple upgrade would work glibc 2.10.x and higher users should be using at least mythtv-0.21_p20877 or newer |