Summary: | media-gfx/gtkimageview: uses -Werror during build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Mounir Lamouri (volkmar) (RETIRED) <volkmar> |
Component: | Current packages | Assignee: | Gentoo Graphics Project <graphics+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra, maekke |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://blog.flameeyes.eu/2009/02/25/future-proof-your-code-dont-use-werror | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 260867 | ||
Attachments: | Fix for another spot where -Werror gets set |
Description
Mounir Lamouri (volkmar) (RETIRED)
2009-06-02 17:42:42 UTC
can I just remove -Werror like that? Index: gtkimageview-1.6.4.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/media-gfx/gtkimageview/gtkimageview-1.6.4.ebuild,v retrieving revision 1.1 diff -u -B -r1.1 gtkimageview-1.6.4.ebuild --- gtkimageview-1.6.4.ebuild 1 Jun 2009 13:25:25 -0000 1.1 +++ gtkimageview-1.6.4.ebuild 2 Jun 2009 22:28:00 -0000 @@ -4,6 +4,8 @@ EAPI="2" +inherit autotools + DESCRIPTION="GtkImageView is a simple image viewer widget for GTK." HOMEPAGE="http://trac.bjourne.webfactional.com/wiki" SRC_URI="http://trac.bjourne.webfactional.com/attachment/wiki/WikiStart/${P}.tar.gz?format=raw @@ -20,6 +22,11 @@ >=x11-libs/gtk+-2.6" RDEPEND="${DEPEND}" +src_prepare() { + sed -i -e '/CFLAGS/s/-Werror //g' configure.in || die + eautoreconf +} + src_test() { # the tests are only built, but not run by default local failed="0" fixed in cvs, thanks for the report. 12 Jun 2009; Markus Meier <maekke@gentoo.org> gtkimageview-1.6.4.ebuild: do not use -Werror during build wrt bug #272301 use gnome eclass and add USE=doc wrt bug #272303 add USE=examples and update mirror wrt bug #272620 Created attachment 195169 [details]
Fix for another spot where -Werror gets set
To close this bug, I think the setting for GNOME_COMPILE_WARNINGS() also needs to be changed, as right now it just adds -Werror to CFLAGS all over again.
This patch switches from 'error' to 'maximum', and drops some redundant CFLAGS additions.
(In reply to comment #3) > To close this bug, I think the setting for GNOME_COMPILE_WARNINGS() also needs > to be changed, as right now it just adds -Werror to CFLAGS all over again. Err, nvm.. WARN_CFLAGS is never used, so it's just cruft in the makefiles. Please disregard. |