| Summary: | media-video/mplayer-1.0_rc2_p20090530: mp3lib patch needs review | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Samuli Suominen (RETIRED) <ssuominen> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | flameeyes, klaus.kusche, lu_zero |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Output when Diego's mp3lib patch is applied, no sounds at all.
The patch that broke MP3 playing. New patch. |
||
|
Description
Samuli Suominen (RETIRED)
2009-05-30 20:51:41 UTC
These are the flags (when downgrading from -9999) [ebuild UD] media-video/mplayer-1.0_rc2_p20090322 [9999] USE="X a52 aac aalib alsa amrnb amrwb ass cddb cdio cdparanoia dirac dts dv dvd dvdnav enca encode faac faad gtk* iconv ipv6 jpeg libcaca live mad mmx mp2 mp3 nemesi network openal opengl png quicktime rar real rtc schroedinger sdl speex sse sse2 ssse3 theora tremor truetype unicode vdpau vorbis x264 xscreensaver xv xvid xvmc -3dnow -3dnowext (-altivec) -arts -bidi -bindist -bl -cpudetection -custom-cflags -custom-cpuopts -debug -dga -directfb -doc -dvb -dxr3 -esd -fbcon -ftp -ggi -gif -jack -joystick -ladspa -lirc -lzo -md5sum -mmxext -mng -musepack -nas -oss -pnm -pulseaudio -pvr -radio -samba (-svga) -teletext -tga -v4l -v4l2 (-vidix) (-win32codecs) -xanim -xinerama -zoran (-nut%) (-osdmenu%*) (-shm%*)" VIDEO_CARDS="nvidia -mga -s3virge -tdfx -vesa" Sounds are back in -9999 and new snapshot mplayer-1.0_rc2_p20090530 Thanks beandog! err.. reopening for tracking purposes Your patch breaks playing MP3 entirely. Reverting the commit you just made. Created attachment 193070 [details]
Output when Diego's mp3lib patch is applied, no sounds at all.
Created attachment 193071 [details, diff]
The patch that broke MP3 playing.
For reference.
strangely here seemed to work, try to use as jump target 0b and 1b... With the patch applied, only way to listen MP3's was to pass -ac mad or -demuxer lavf to commandline (advises from #mplayer) (In reply to comment #8) > With the patch applied, only way to listen MP3's was to pass > -demuxer lavf Or was that -afm ffmpeg.. one of them, grepping .bash_history (rebuilding mplayer with and without the patch takes a good while, i'll try again tonight) [Would have been nice to be CCed at the first round; btw here it worked fine, but I have to say that it might be related to my flags just like for the failures...] I can confirm that I can (still) play mp3s with Luca's patch modified to use 0b 1b instead of just 0 and 1 during jumps. Samuli can you try with that change please? For me, that patch makes mplayer SIGSEGVing (on x86-64): Old version of mplayer-1.0_rc2_p20090322 ebuild without that patch worked fine, new version of ebuild with that patch SIGSEGV's mplayer with a NULL pointer. Last message before SIGSEGV is about loading mp3lib. + 03 Jun 2009; Samuli Suominen <ssuominen@gentoo.org> + mplayer-1.0_rc2_p20090322.ebuild, mplayer-1.0_rc2_p20090530.ebuild, + -files/mplayer-1.0_rc2_p20090322-fix-mp3lib-use-local-labels.patch, + +files/mplayer-1.0_rc2_p20090530-fix-mp3lib-use-local-labels-2.patch: + Modify fix-mp3lib-use-local-labels to use jump 0b and 1b instead of 0 and + 1 wrt #271906, thanks to Luca Barbato. Remove the broken patch from old + version. I hope I got this right. Works for me. Please review, and if OK, please Luca commit to upstream. Created attachment 193342 [details, diff]
New patch.
New patch. Works here, please review.
Works here too, thanks Samuli! (In reply to comment #13) > + 03 Jun 2009; Samuli Suominen <ssuominen@gentoo.org> > + mplayer-1.0_rc2_p20090322.ebuild, mplayer-1.0_rc2_p20090530.ebuild, > + -files/mplayer-1.0_rc2_p20090322-fix-mp3lib-use-local-labels.patch, > + +files/mplayer-1.0_rc2_p20090530-fix-mp3lib-use-local-labels-2.patch: > + Modify fix-mp3lib-use-local-labels to use jump 0b and 1b instead of 0 and > + 1 wrt #271906, thanks to Luca Barbato. Remove the broken patch from old > + version. > > I hope I got this right. Works for me. > > Please review, and if OK, please Luca commit to upstream. > *poke* :) ? According to Luca it was posted on mplayer-dev-eng already; and I accidentally double-posted it today.. Should be enough posting :P |