Summary: | enewuser fails; argument order to adduser is wrong; patch attached. | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Wicher Minnaard <wicher> |
Component: | Prefix Support | Assignee: | Gentoo Prefix <prefix> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | base-system |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Solaris | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Patch to usr/portage/eclass/eutils.class
Testcase for enewuser |
Description
Wicher Minnaard
2009-05-24 15:56:35 UTC
Created attachment 192311 [details, diff]
Patch to usr/portage/eclass/eutils.class
Created attachment 192313 [details]
Testcase for enewuser
(In reply to comment #1) > Created an attachment (id=192311) [edit] > Patch to usr/portage/eclass/eutils.class > Would you mind adding a proper case for solaris? Match on *-solaris* I would ;-) I thought about that, but the thing that stopped me from doing exactly that is that I've never seen an 'adduser' that tolerates arguments after the 'login' argument. Therefore, the fallback case in eutils.class looked wrong to me, so I patched that. Do you know of any 'adduser' programs on niche Unixoids that *do take* arguments _after_ the 'login' argument? That would change things. This problem is still exists as of 10/18/2009. Solaris expects "useradd" to end with the login name. I'm not aware of any "unix-oid" OS that allows anything to follow the login name. hmmm, that patch actually looks pretty trivial... @base-system: would you prefer a new case for *-solaris*, or is moving the ${euser} to the end (as last argument) also acceptable? moving $euser to the end is fine. the proposed patch here has incorrect indentation though, so make sure you dont commit that :p. That patch is probably on an outdated version of eutils.eclass, but the idea is the same. I committed the change, thanks and sorry for the long wait. |