Bug 262945 – x11-apps/ttmkfdir ignores LDFLAGS

• Product: Gentoo Linux
• Status: RESOLVED WONTFIX

[Description Davide Pesavento (RETIRED) 2009-03-18 17:54:28 UTC]

QA Notice: Files built without respecting LDFLAGS have been detected
 Please include the following list of files in your report:
/usr/bin/ttmkfdir

[Comment 1 Kevin Pyle 2009-03-19 04:27:55 UTC]

Created attachment 185483 [details, diff]
Patch to $S/Makefile to avoid overwriting LDFLAGS

The upstream Makefile overwrites user LDFLAGS, and abuses LDFLAGS to link to required libraries.  This patch fixes both issues, by moving the libraries to LDLIBS and changing the rule for building ttmkfdir to follow the GNU make standard for linking C++ programs.

[Comment 2 Davide Pesavento (RETIRED) 2009-03-19 10:17:05 UTC]

Shouldn't $(LDLIBS) go after "-o $@" in the linking phase to avoid --as-needed failures?

[Comment 3 Davide Pesavento (RETIRED) 2009-03-19 10:25:43 UTC]

(In reply to comment #2)
> Shouldn't $(LDLIBS) go after "-o $@" in the linking phase to avoid --as-needed
> failures?
> 

Sorry... ignore my previous comment. $(LDLIBS) must go after $^, not $@.
I'm still sleeping :P

[Comment 4 Rémi Cardona (RETIRED) 2009-03-19 10:43:07 UTC]

Please send this patch to the appropriate upstream bug tracker. Please paste the url here so we can track it.

Thanks

[Comment 5 Kevin Pyle 2009-03-21 04:17:39 UTC]

The value of $HOMEPAGE points to a document which was last modified 05 Feb 2000.  There is no sign of a bug tracker from that page, nor any obvious Google hits.  The best candidate seems to be that Red Hat has taken over maintenance, as evidenced by a comment in the ttmkfdir spec file maintained by the Fedora project <http://cvs.fedoraproject.org/viewvc/devel/ttmkfdir/ttmkfdir.spec?view=markup>:

# This is a Red Hat maintained package which is specific to
# our distribution.  Thus the source is only available from
# within this srpm.
Source0: %{name}-%{version}.tar.bz2

Davide, as the original reporter, would you like to do the honor of notifying the upstream maintainers?

[Comment 6 Davide Pesavento (RETIRED) 2009-03-22 13:44:04 UTC]

(In reply to comment #5)
> Davide, as the original reporter, would you like to do the honor of notifying
> the upstream maintainers?
> 

I'll leave that to you if you so please. I have very little time in these days and you can probably interact better with upstream if needed... and the patch is yours after all.

[Comment 7 Rémi Cardona (RETIRED) 2009-12-13 15:59:03 UTC]

Package is getting treecleaned, see bug #293177 for more info.

Thanks