Summary: | sys-block/mbuffer-20090113 fails to make - missing ksh | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Volker Hemmann <volkerarmin> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chad.simmons, john_r_graham |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
the build.log
Patch to the Makefile.in to only use /bin/ksh if no shell is defined. New ebuild that applies the patch. Better patch. Update to ebuild. |
Description
Volker Hemmann
2009-02-09 19:31:26 UTC
Created attachment 181474 [details]
the build.log
Created attachment 181726 [details, diff]
Patch to the Makefile.in to only use /bin/ksh if no shell is defined.
At some point the author defaulted the SHELL to "/bin/ksh". It didn't used to be that way. Patch submitted to upstream as well.
- John
Created attachment 181728 [details]
New ebuild that applies the patch.
This ebuild applies the patch and re-runs the autotools before compiling.
- John
yeah, using anything other than /bin/sh is just stupid imo. thanks for contacting upstream about the issue. Created attachment 181819 [details, diff]
Better patch.
More sophisticated patch, moves the selection of the build shell into the autotools, prefers ksh if available but falls back to bash and then sh (in that order) if not available.
Created attachment 181820 [details]
Update to ebuild.
Just changes the patch name, bolsters the comments somewhat.
i'll just sed the Makefile.in to /bin/sh to avoid having to run autotools. thanks for getting this resolved upstream. http://sources.gentoo.org/sys-block/mbuffer/mbuffer-20090113.ebuild?r1=1.1&r2=1.2 Fixed upstream as well in a new release: mbuffer-20090215. Current mbuffer-20090113 tarball remains unmodified (as it should). - John |