Summary: | style change for e2fsprogs-1.41.3-r1.ebuild | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeremy Olexa (darkside) (RETIRED) <darkside> |
Component: | New packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED INVALID | ||
Severity: | enhancement | CC: | alanh, prefix |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Jeremy Olexa (darkside) (RETIRED)
2009-01-27 17:01:11 UTC
(In reply to comment #0) > This is queued up in my cvs > workspace if you preferred that I commit it as is. TIA. Approved Jeremy, please proceed with a revision bump. umm, why ? it results in the exact same call to econf unless i missed something. (In reply to comment #2) > umm, why ? it results in the exact same call to econf unless i missed > something. > That is correct. However for ~m68k-mint, we need to not specify any --enable-$libtype-libs - the current ebuild does not allow that. This _style_ change that I proposed will allow us to do the following: *-darwin*) myconf="${myconf} --enable-bsd-shlibs";; *mint*) ;; *) myconf="${myconf} --enable-elf-shlibs";; See the blocking bug 256234 for a rational if desired. I think vapier was querying why a version bump was necessary as it doesn't change the build itself. (In reply to comment #4) > I think vapier was querying why a version bump was necessary as it doesn't > change the build itself. > Its not a version bump, I have never said it was =/ This _style_ change (emphasis added for the 3rd time now) is merely so we have one line diff in Gentoo Prefix compared to a ~6-8 line diff. This matters when auto-syncing and reviewing changes.. So, I'll commit it tonight unless there is an uproar between now and then. ;) then you should merge all the changes rather than simply mucking with the style. i dont see the point of maintaining a change externally here. otherwise i'll be inclined in the future to forget and change it back (after all, the ebuild was the way you want it now but i changed it to condense code a bit). and yes, there should be no rev bump here Cool ! (In reply to comment #6) > then you should merge all the changes rather than simply mucking with the > style. i dont see the point of maintaining a change externally here. > otherwise i'll be inclined in the future to forget and change it back (after > all, the ebuild was the way you want it now but i changed it to condense code a > bit). Ok..if you say so. I'm going to be applying all of bug 256234 to gentoo-x86. That is, cracklib, e2fsprogs, e2fsprogs-libs as well as one patch in FILESDIR. I'll be home in ~4 hours, I'll check back then. This can be handled in bug 256234 directly. Making this bug pretty irrelevant -> INVALID. I'll CC base-system on the other bug. |