Summary: | Mercurial eclass should use hg clone instead of rsync to create ${WORKDIR}/${module} | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arne Babenhauserheide <arne_bab> |
Component: | Eclasses | Assignee: | Krzysztof Pawlik (RETIRED) <nelchael> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dberkholz, jer, zzam |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 259898 | ||
Bug Blocks: | |||
Attachments: |
mercurial.eclass.diff
mercurial.eclass |
Description
Arne Babenhauserheide
2009-01-19 22:00:03 UTC
Created attachment 179038 [details]
mercurial.eclass.diff
Sidenote: I also adapted my local the mercurial.eclass to fix #238314 and #160565 - should I also attach that instead of creating several diffs which depend on each other? Why do I get this bug? I also just use it from my v4l-dvb-hg ebuild and have no stronger relation to that eclass. Only thing I could do would be: Apply patch, emerge v4l-dvb-hg and in case it does not error: commit So someone with time should review it and commit if it works Should I also attach the version which fixes #238314 and #160565? Or should I create patches one by one? You got it because the only person ever to commit to it retired in 2006, and one of his commits said this: revision 1.2 date: 2006-06-08 08:47:17 -0700; author: agriffis; state: Exp; lines: +22 -17; commitid: f11448846844567; Update mercurial.eclass per conversation with zzam, http://article.gmane.org/gmane.linux.gentoo.devel/38465 Do you want to take responsibility for this eclass or leave it orphaned? Adding dev-util/mercurial maintainer. :) Created attachment 180242 [details]
mercurial.eclass
Supports #251163 and fixes #238314 and #160565.
This version contains changes from all three bugs, since I worked on all three parts together. I'm sorry that I don't have three clean patches instead.
I can turn it into three patches, if it help you.
It will take me a bit, though.
CC cleanup. Could you please test patch against mercurial.eclass from bug 259898 ? (In reply to comment #9) > CC cleanup. Please, don't do that. And if you do, make notes that the involved persons explicitly stated they wanted their CC removed. Fixed by bug #259898. |