Summary: | =sys-apps/findutils-4.5.3 fails its testsuite | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Gilles Dartiguelongue (RETIRED) <eva> |
Component: | New packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kanelxake, nfortino |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://savannah.gnu.org/bugs/index.php?25359 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
Proposed patch Backported upstream patch |
Description
Gilles Dartiguelongue (RETIRED)
2008-12-30 11:09:53 UTC
Created attachment 176859 [details]
build.log
This seems to be fixed by undoing an optimization change made upstream: http://git.savannah.gnu.org/cgit/findutils.git/commit/?id=acb82fe44369c108b43ec3e805aa94bf28352d0a Undoing this commit fixes the test failures. Upstream bug submitted: http://savannah.gnu.org/bugs/index.php?25359 Created attachment 179035 [details, diff]
Proposed patch
Created attachment 183835 [details, diff]
Backported upstream patch
This has been resolved upstream, see the upstream bug in the above comment for details.
Backported patch attached.
(In reply to comment #4) > Created an attachment (id=183835) [edit] > Backported upstream patch > > This has been resolved upstream, see the upstream bug in the above comment for > details. > > Backported patch attached. > How come your patch is so much shorter then the last patch posted upstream, and also shorter then the one that acctually made it into git [1]? Also you may consider following Mikes suggestions for patches [2]. [1] http://git.savannah.gnu.org/cgit/findutils.git/commit/?id=b445af98c22cd2d13673e2699a77ab728a7073b0 [2] http://dev.gentoo.org/~vapier/clean-patches (In reply to comment #5) The patch is so short because it only changes the code, not the ChangeLog and unit tests. I didn't think it was appropriate to keep around ChangeLog entries which are designed to be in 4.5.4 in a 4.5.3 backport. Also, the upstream patch undoes the first pass at fixing the bug, and then applies this patch. Obviously, the 4.5.3 release doesn't have a first pass at fixing the bug, so there is no need to revert it. As for cleaning patches, I have read that, and usually use it (see my old patch), but I failed this time around :( thanks, added the patch to 4.5.3-r1 (In reply to comment #6) Thanks for the information, nice to see you fix it and take it upstream, and thanks vapier for handling it quickly now when a patch was avaible. |