Summary: | app-text/jpdftweak-0.9 - new ebuild | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jiri Tyr <jiri.tyr> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | java |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://jpdftweak.sourceforge.net | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
jpdftweak-0.9.ebuild
jpdftweak-0.9.ebuild Patch against Attachment #175738 Patch against Attachment #175738 jpdftweak-0.9.ebuild jpdftweak-0.9.ebuild |
Description
Jiri Tyr
2008-12-18 09:42:51 UTC
Created attachment 175688 [details]
jpdftweak-0.9.ebuild
Ebuild for the jpdftweak-0.9.
Reassigning... Jiri, please wrap quotation-marks around each ${S}: ${S} should become "${S}" (In reply to comment #1) > Created an attachment (id=175688) [edit] > jpdftweak-0.9.ebuild > > Ebuild for the jpdftweak-0.9. > * java-pkg_jar-from takes a third argument as the name of the symlink. * ant-core dependency is handled by eclasses. * make_desktop_entry should take just ${PN} as 1st param. * dodoc should die in case of an error. Created attachment 175738 [details]
jpdftweak-0.9.ebuild
Some corrections. Thanks to Serkan Kaba.
Created attachment 175773 [details, diff] Patch against Attachment #175738 [details] I'm adding a patch against your latest ebuild that fixes more issues that I, repoman and java-dep-check discovered. * GPL is not a valid license in ${PORTDIR}/licenses. * IUSE should be defined even if it's empty. * dev-java/bcmail dev-java/bcprov are indirect dependencies. * Proguard is just used in building static jar. * cd should die on error. Created attachment 175779 [details, diff] Patch against Attachment #175738 [details] This fixes another issue. You're already at $WORKDIR after src_unpack. Also please consider talking us on #gentoo-java @FreeNode and contibuting your ebuild(s) to overlays. Thanks, Serkan Created attachment 176462 [details]
jpdftweak-0.9.ebuild
Some corrections for jpdftweak-0.9. Thanks to Serkan.
(In reply to comment #7) > Created an attachment (id=176462) [edit] > jpdftweak-0.9.ebuild > > Some corrections for jpdftweak-0.9. Thanks to Serkan. > Just a tiny bit I didn't notice before doXXX calls do not need the $S prefix since you're already located at $S in src_install Created attachment 176616 [details]
jpdftweak-0.9.ebuild
Removed the ${S} from all doxxx commands.
(In reply to comment #9) > Created an attachment (id=176616) [edit] > jpdftweak-0.9.ebuild > > Removed the ${S} from all doxxx commands. > Looks good except the desktop file looks for an icon that's KDE only. Maybe we could pass that until upstream has a proper logo/icon. Also you may consider getting involved via #gentoo-java @ FreeNode or posting to Java ML (gentoo-java@lists.gentoo.org) where you may get more guidance. Also you may get access to our overlays to maintain it yourself. Thanks, Serkan Added to portage. Thanks for the ebuild. |