Bug 24504 - d4x-2.4.1-r1 fails to compile
Bug#: 24504 Product:  Gentoo Linux Version: unspecified Platform: x86
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: liquidx@gentoo.org Reported By: andreas.kotowicz@gmail.com
Component: Applications
URL: 
Summary: d4x-2.4.1-r1 fails to compile
Keywords:  
Status Whiteboard: 
Opened: 2003-07-15 00:00 0000
Description:   Opened: 2003-07-15 00:00 0000
here's what i get:

g++ -DHAVE_CONFIG_H -I. -I. -I../..   -I/usr/include/glib-2.0 -I/usr/lib/glib-2.
0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1
.0 -I/usr/include/pango-1.0 -I/usr/X11R6/include -I/usr/include/freetype2 -inclu
de ../../config.h  -O2 -mcpu=i686 -pipe   -c -o filtrgui.o `test -f 'filtrgui.cc
' || echo './'`filtrgui.cc
prefs.cc: In function `void d4x_prefs_search()':
prefs.cc:813: `gtk_radio_menu_item_group' undeclared (first use this function)
prefs.cc:813: (Each undeclared identifier is reported only once for each
   function it appears in.)
make[3]: *** [prefs.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/var/tmp/portage/d4x-2.4.1-r1/work/d4x-2.4.1/main/fa ce'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/d4x-2.4.1-r1/work/d4x-2.4.1/main'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/d4x-2.4.1-r1/work/d4x-2.4.1'
make: *** [all] Error 2

------- Comment #1 From Nicolas Kaiser 2003-07-15 07:05:36 0000 -------
Can confirm. I had a look at 2.5.0beta2, and that version does compile without
the error.

--- /usr/portage/net-misc/d4x/d4x-2.4.1-r1.ebuild       2003-07-13
16:37:45.000000000 +0200
+++ /usr/portage/net-misc/d4x/d4x-2.4.99.ebuild 2003-07-15 15:52:11.000000000
+0200
@@ -6,6 +6,7 @@

 inherit eutils

+P="d4x-2.5.0beta2"
 S="${WORKDIR}/${P/_}"
 DESCRIPTION="GTK based download manager for X."
 SRC_URI="http://www.krasu.ru/soft/chuchelo/files/${P/_}.tar.gz"
@@ -32,7 +33,7 @@

        # Fix a miscompile with gcc-3.2.2 and CFLAGS="-O2"
        # <azarah@gentoo.org> (30 Mar 2003)
-       epatch ${FILESDIR}/${P}-fix-statusbar-crash.patch
+       epatch ${FILESDIR}/${PN}-2.4.1-fix-statusbar-crash.patch
 }

 src_compile() {

------- Comment #2 From Kfir Ozer 2003-08-16 01:09:35 0000 -------
yea.. i changed the name of the ebuild to dx4-2.5.0_beta2.ebuild
and removed the all src_unpack() part and it compiles just fine without any problems.

------- Comment #3 From Alastair Tse (RETIRED) 2003-08-31 07:54:23 0000 -------
thanks. committed new version to portage.

------- Comment #4 From Peter 2003-10-13 01:46:50 0000 -------
Created an attachment (id=19164) [details]
Name self-descriptive.

------- Comment #5 From Peter 2003-10-13 01:51:31 0000 -------
(From update of attachment 19164 [details])
Put this patch in the d4x/files dirrectory...
End then look the next atachment for the ebuild.

------- Comment #6 From Peter 2003-10-13 01:53:09 0000 -------
Created an attachment (id=19165) [details]
ebuil

This is ebuild which I changed to apply patch. See the previos posting.

------- Comment #7 From Peter 2003-10-13 02:00:33 0000 -------
Posting #5 and #6 are patch and ebuild to apply patch that fixes the compile
time problem. This problem is because of gtk_radio_menu_item_group() function
wich is in new version of gtk (file: /usr/include/gtk-2.0/gtk/gtkradiomenuitem.h):

#ifndef GTK_DISABLE_DEPRECATED
#define gtk_radio_menu_item_group gtk_radio_menu_item_get_group
#endif

So the patch just changes gtk_radio_menu_item_group on gtk_radio_menu_item_get_group,
so to allow us to compile.

I think this information is enought to fix the 2.4.1 ebuild.