Bug 244847

Summary:	sys-devel/distcc-3.0-r3 - strip -Werror
Product:	Gentoo Linux	Reporter:	Ryan Hill (RETIRED) <rhill>
Component:	[OLD] Core system	Assignee:	MATSUU Takuto (RETIRED) <matsuu>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ed, manuel.lauss
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://code.google.com/p/distcc/issues/detail?id=28
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	distcc-3.0-werror.diff uninitialized.patch

Description Ryan Hill (RETIRED) gentoo-dev

2008-10-29 02:14:30 UTC

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/etc\"" -DPKGDATADIR="\"/usr/share/distcc\"" -Isrc -I"./src" -I"./lzo"  -Werror -O3 -march=core2 -fomit-frame-pointer -pipe -MD -W -Wall -Wimplicit -Wuninitialized -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wmissing-declarations -D_REENTRANT   -pthread -o src/where.o -c src/where.c

cc1: warnings being treated as errors
src/where.c: In function 'dcc_lock_local_cpp':
src/where.c:193: error: 'chosen' may be used uninitialized in this function
make: *** [src/where.o] Error 1

Comment 1 Ryan Hill (RETIRED) gentoo-dev

2008-10-29 02:15:02 UTC

Created attachment 170182 [details, diff]
distcc-3.0-werror.diff

Comment 2 MATSUU Takuto (RETIRED) gentoo-dev

2008-10-29 07:44:55 UTC

I reported to upstream.
http://code.google.com/p/distcc/issues/detail?id=28
http://distcc.googlecode.com/issues/attachment?aid=6181885209652935876&name=src-where-uninitialized.patch

Could you test the patch? I'll commit it to portage tree.

Comment 3 Ed Catmur 2008-11-01 00:27:41 UTC

Created attachment 170434 [details, diff]
uninitialized.patch

Or, you could fix the bug.

Comment 4 MATSUU Takuto (RETIRED) gentoo-dev

2008-11-05 22:53:37 UTC

Fixed in distcc-3.0-r4

Comment 5 Manuel Lauss 2008-11-10 07:26:25 UTC

-Werror is still problematic on at least MIPS and SH-4 (gcc-4.3.2):

sh4-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/etc\"" -DPKGDATADIR="\"/usr/share/distcc\"" -Isrc -I"./src" -I"./lzo"  -Werror -Os -m4 -ml -fomit-frame-pointer -ffast-math --param max-aliased-vops=10000 -MD -W -Wall -Wimplicit -Wuninitialized -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wmissing-declarations -pthread -o src/srvnet.o -c src/srvnet.c
cc1: warnings being treated as errors
src/srvnet.c: In function 'dcc_check_client':
src/srvnet.c:264: error: cast increases required alignment of target type
src/srvnet.c:269: error: cast increases required alignment of target type
make: *** [src/srvnet.o] Error 1

()

Comment 6 MATSUU Takuto (RETIRED) gentoo-dev

2008-11-10 23:46:38 UTC

ok. removed -Werror in distcc-3.0-r4.