Bug 240280 - dev-util/git: C(XX)FLAGS are ignored (at src_configure/compile)
Bug#: 240280 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: ferdy@gentoo.org Reported By: flameeyes@gentoo.org
Component: Ebuilds
URL: 
Summary: dev-util/git: C(XX)FLAGS are ignored (at src_configure/compile)
Keywords:  
Status Whiteboard: 
Opened: 2008-10-06 13:36 0000
Description:   Opened: 2008-10-06 13:36 0000
I don't know the build system for this program (and this is a generic bug
template so I cannot tell you which program exactly is), but my tests shows
that it's not respecting CFLAGS (or CXXFLAGS) properly.

Please look into it, since it's important to respect user CFLAGS and CXXFLAGS.

Warning: this bug might look like a false positive because you actually have
your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the
build system during src_unpack/src_prepare. While QA has not as of this moment
expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone
approach, so that ebuild commands could work to reproduce the actual results.

To avoid the set in stone approach:

- consider just changing CFLAGS= to CFLAGS+= if the build system enables
warnings;
- if the buildsystem does not use CFLAGS variable at all, in the sed use
'$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up;
- use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS.

Thanks,
Diego

------- Comment #1 From Robin Johnson 2008-11-24 01:23:42 0000 -------
Fixed in ~arch tip ebuild of CVS.