Summary: | sys-apps/portage changed 'doins' behaviour with version 2.1.5.6 till now (2.2_rc11) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Markus Rathgeb <maggu2810> |
Component: | [OLD] Core system | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | major | Keywords: | InVCS, REGRESSION |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.gentoo.org/proj/en/portage/index.xml | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 210077 | ||
Attachments: |
fix cases where arguments are symlinks to directories
fix cases where arguments are symlinks to directories |
Description
Markus Rathgeb
2008-10-04 11:06:56 UTC
I guess the difference in behavior was probably introduced by the changes from bug #210575. I'll see about changing it back. Created attachment 167242 [details, diff]
fix cases where arguments are symlinks to directories
If this patch is saved as /tmp/doins_sym.patch, then it can be applied as follows:
patch /usr/lib/portage/bin/doins /tmp/doins_sym.patch
The patch fixed the problem. Thanks! Can you have a look at: http://bugs.gentoo.org/show_bug.cgi?id=239128 I am not sure, if this bug should depend on the other bug or the other bug should depent on this bug. Oh, sorry, I answered to fast. The files are installed - okay. But the name of the directory is wrong folder 'b' is a symbolic link to folder 'a' b -> a After a "doins -r b/" the folder 'b' should be installed and the name for the folder should be 'b'. In your patch, the name 'a' is used. Created attachment 167312 [details, diff] fix cases where arguments are symlinks to directories (In reply to comment #3) > Can you have a look at: > http://bugs.gentoo.org/show_bug.cgi?id=239128 > > I am not sure, if > this bug should depend on the other bug > or > the other bug should depent on this bug. > It's really a duplicate of this bug. You can reopen it and mark it as such. *** Bug 239128 has been marked as a duplicate of this bug. *** This seems okay now, thanks again. Today I have no time to have a clearer look at the patch, but in the next day... Perhaps the usage of 'mktemp' for .doins_tmp is better. But you will surely know it better. This is fixed in 2.2_rc12. (In reply to comment #7) > This seems okay now, thanks again. Thanks for testing. > Today I have no time to have a clearer look at the patch, but in the next > day... > Perhaps the usage of 'mktemp' for .doins_tmp is better. But you will surely > know it better. Well, there's practically zero chance of a name collision here so mktemp shouldn't be necessary. Also, we try to avoid dependencies on random binaries like that. I suppose we can probably rely on mktemp being available though, but still, it's not really needed. |