Summary: | repoman should warn if there is an econf call in eapi2_src_compile | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexis Ballier <aballier> |
Component: | Current packages | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | Keywords: | InVCS |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 210077, 288499 |
Description
Alexis Ballier
2008-09-29 18:40:30 UTC
(In reply to comment #0) > After seeing double econfs or, worse, build failures when converting ebuilds to > eapi-2 with the new src_configure phase, I think it could be a good idea to > display warnings if there is an econf call in eapi2_src_compile. > However, I must admit I have absolutely no clue on how to do this :( > A global in econf that only lets you call it once if EAPI=2 is supported? Messy... First we need to know how likely it is that ebuilds will migrate to EAPI 2 without also splitting out src_configure from src_compile. In svn r11603 there's a related eqawarn message: ! hasq "$EAPI" 0 1 && [[ $EBUILD_PHASE = compile && \ $(type -t src_configure) = function ]] && \ eqawarn "econf called in src_compile instead of src_configure" There's a new SrcCompileEconf check by Markus Meier <maekke@gentoo.org> in svn r13717. This is fixed in 2.1.7. |