Bug 238891 – app-cdr/cdrdao-1.2.2-r2 - fails to create toc file - patch included

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description A. Person 2008-09-27 18:42:06 UTC]

Trying to run this command:

cdrdao read-cd --paranoia-mode 0 --device /dev/cdrom --datafile CD/cdda.bin CD/cdda.toc

on the Daniel Johnston CD "1990" results in the following error:

cdrdao: Track.cc:1415: void Track::addCdTextItem(CdTextItem*): Assertion `CdTextItem::isTrackPack(item->packType())' failed.

The problem is described here and a patch is presented:

http://www.lackhead.org/2007/05/patch-for-cdrdao-122-cd-text-causing-crash/

If I apply the patch, the problem is fixed.  However, toc2cue then chokes on the toc file with a series of:

ERROR: CD/cdda.toc:36: Invalid CD-TEXT item for a track.

Should the cdrdao patch above be included as -r3?  Does anyone know how to modify toc2cue to get it to accept the toc file?

Reproducible: Always

[Comment 1 Jeroen Roovers (RETIRED) 2008-09-29 16:39:18 UTC]

Please post your `emerge --info' and specify which version of cdrdao you are/were using/patching.

[Comment 2 A. Person 2008-10-01 01:46:24 UTC]

I was patching app-cdr/cdrdao-1.2.2-r2.

# emerge --info
Portage 2.1.4.4 (hardened/amd64/multilib, gcc-3.4.6, glibc-2.6.1-r0, 2.6.25-gentoo-r5 x86_64)
=================================================================
System uname: 2.6.25-gentoo-r5 x86_64 Intel(R) Pentium(R) Dual CPU T2310 @ 1.46GHz
Timestamp of tree: Tue, 30 Sep 2008 15:45:04 +0000
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r13, 2.5.2-r7
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r2
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nocona -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS=""
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig buildpkg distlocks metadata-transfer sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LINGUAS="en_US"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.us.gentoo.org/gentoo-portage"
USE="X a52 acl acpi alsa amd64 bash-completion berkdb bzip2 cairo caps cdaudio cdda cddb cdr cracklib crypt cups dbus dhcp divx dri dts dvd encode exif ffmpeg firefox flac gd gif gimp gmedia gmp gnutls gpm grammar gsm gtk gtkhtml hal hardened hddtemp hpn imap java jpeg justify lcms lm_sensors mad madwifi matroska md5sum midi mng mono mp3 mpeg musepack musicbrainz ncurses new-login nptl nptlonly nsplugin offensive ogg opengl oss pam pdf perl pic png python qt3support quicktime quotes readline realmedia regex rt73usb rtc sdl sdl-image session speex spell sse sse2 ssl startup-notification svg tagwriting tcpd theora thesaurus tiff truetype unicode urandom usb vcd vim-with-x vlm vorbis wmf wmp wxwindows x264 xcomposite xml xorg xprint xscreensaver xulrunner xv zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en_US" USERLAND="GNU" VIDEO_CARDS="i810"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 3 A. Person 2008-10-06 16:33:30 UTC]

Created attachment 167466 [details, diff]
toc2cue CD-TEXT fix

[Comment 4 A. Person 2008-10-06 16:36:13 UTC]

This patch also fixes the toc2cue problem.  I think the patch I linked to above only needs the new CDTEXT_DISK_ID line to fix the problem I ran into.  It may always only need that line.

Can we get these in Portage?

[Comment 5 A. Person 2008-12-13 21:13:20 UTC]

May I ask why these patches aren't being introduced into Portage?

[Comment 6 Samuli Suominen (RETIRED) 2008-12-13 22:23:08 UTC]

(In reply to comment #5)
> May I ask why these patches aren't being introduced into Portage?
> 

Time. Other bugs. Priorities.

[Comment 7 Peter Alfredsen (RETIRED) 2008-12-13 22:36:01 UTC]

I remember looking at this when it was submitted and thinking that we should import some patches from Debian, but never really got that done.

[Comment 8 A. Person 2008-12-13 22:37:32 UTC]

These two patches are extremely simple and work perfectly.

[Comment 9 Peter Alfredsen (RETIRED) 2009-02-01 01:42:55 UTC]

Thanks for your patience.
+*cdrdao-1.2.2-r3 (01 Feb 2009)
+
+  01 Feb 2009; Peter Alfredsen <[e-mail]>
+  +files/cdrdao-1.2.2-cdtext.patch, +files/cdrdao-1.2.2-device.patch,
+  +files/cdrdao-1.2.2-toc2cue.patch, +files/cdrdao-1.2.2-tocparser.patch,
+  +cdrdao-1.2.2-r3.ebuild:
+  EAPI-2, fix bug 238891, CDTEXT and toc2cue problems. Import patches from
+  Debian for a few issues. Remove RESTRICT=strip, which seems to be
+  left-overs from a user-submitted ebuild in bug 43003.
+