Bug 235229 - app-admin/ulogd change deps for USE=postgres
Bug#: 235229 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: minor Priority: P2
Resolution: FIXED Assigned To: maintainer-needed@gentoo.org Reported By: christian@bricart.de
Component: Ebuilds
URL: 
Summary: app-admin/ulogd change deps for USE=postgres
Keywords:  
Status Whiteboard: 
Opened: 2008-08-19 20:53 0000
Description:   Opened: 2008-08-19 20:53 0000 
app-admin/ulogd-1.23-r1 introduced "DEPEND ( ... postgres?
virtual/postgresql-server )W
--> virtual/postgresql-base should be enough here. - maybe introduce new
USE=-minimal for DEPEND on full postgresql-server..?

Reproducible: Always

Steps to Reproduce:
(trivial)

------- Comment #1 From Jeremy Olexa (darkside) 2008-08-19 21:00:15 0000 ------- 
hmm, i'm fine with just postgresql-base. Have you tested that and does it work
fine?

------- Comment #2 From Christian Bricart 2008-08-19 21:11:40 0000 ------- 
actually not, yet ;-) but it used to function some ebuilds before with just
dev-db/libpq installed ;-) 

apart from that - as described above, you'll still need
DEPEND=virtual/postgresql-server when your log target is not localhost..

------- Comment #3 From Jeremy Olexa (darkside) 2008-08-19 21:15:35 0000 ------- 
(In reply to comment #2)
> actually not, yet ;-) but it used to function some ebuilds before with just
> dev-db/libpq installed ;-) 
> 
> apart from that - as described above, you'll still need
> DEPEND=virtual/postgresql-server when your log target is not localhost..
> 

ugh. I'd rather not introduce another use flag on something that I don't
maintain myself.

------- Comment #4 From Christian Bricart 2008-08-19 21:26:45 0000 ------- 
so I'll test if:

DEPEND="net-firewall/iptables
        mysql? ( virtual/mysql )
        postgres? ( virtual/postgresql-base )"

is enough for a remote database.
And we'll keep DEPEND="virtual/postgresql-server" to the user that knows best
if [s]he want's a local database as target?

------- Comment #5 From Jeremy Olexa (darkside) 2008-08-19 21:51:06 0000 ------- 
(In reply to comment #4)
> so I'll test if:
> 
> DEPEND="net-firewall/iptables
>         mysql? ( virtual/mysql )
>         postgres? ( virtual/postgresql-base )"
> 
> is enough for a remote database.
> And we'll keep DEPEND="virtual/postgresql-server" to the user that knows best
> if [s]he want's a local database as target?

Yea, sounds good. Or we could just do:

postgres? || ( virtual/postgresql-base virtual/postgresql-server )

That way it will prefer the -base but accept -server as well. I can only assume
that if the user has a remote log target then they would already have -server
installed. What do you think?

------- Comment #6 From Christian Bricart 2008-08-20 07:35:25 0000 ------- 
(In reply to comment #5)
> Yea, sounds good. Or we could just do:
> 
> postgres? || ( virtual/postgresql-base virtual/postgresql-server )
> 

dev-db/postgresql-server has RDEPEND=dev-db/postgresql-base set
so *-server pulls *-base anyway

> That way it will prefer the -base but accept -server as well. I can only assume
> that if the user has a remote log target then they would already have -server
> installed. What do you think?
> 

I've tested for proper functioning with:
-       postgres? ( virtual/postgresql-server )"
+       postgres? ( virtual/postgresql-base )"

-> WORKSFORME (=ulogd-1.23-r3)

------- Comment #7 From Jeremy Olexa (darkside) 2008-08-27 04:27:37 0000 ------- 
> I've tested for proper functioning with:
> -       postgres? ( virtual/postgresql-server )"
> +       postgres? ( virtual/postgresql-base )"
> 
> -> WORKSFORME (=ulogd-1.23-r3)

Thanks for testing. Does not warrant a revbump though. Committed.