Bug 234790 - media-libs/xine-lib: check for possible removal of hppa specific stuff in xine-libs's ebuilds
Bug#: 234790 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: hppa@gentoo.org Reported By: aballier@gentoo.org
Component: Applications
URL: 
Summary: media-libs/xine-lib: check for possible removal of hppa specific stuff in xine-libs's ebuilds
Keywords:  
Status Whiteboard: 
Opened: 2008-08-15 07:16 0000
Description:   Opened: 2008-08-15 07:16 0000 
Currently there is that in xine-lib's ebuild:
    # The default CFLAGS (-O) is the only thing working on hppa.
    use hppa && unset CFLAGS

Which was apparently added a good bunch of time ago:
http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/xine-lib/xine-lib-1_rc4-r1.ebuild?hideattic=0&r1=1.4&r2=1.5


One thing I hate with such code is that it tends to stay forever. I think it
could be worth checking again if it is safe to remove it. If it isn't it'll
still probably be better to use strip-flags or something like that instead of
completely unsetting the CFLAGS.

------- Comment #1 From Jeroen Roovers 2008-08-15 15:54:23 0000 ------- 
I'll test it soon with something better than -O.

------- Comment #2 From Jeroen Roovers 2008-08-15 17:04:55 0000 ------- 
It simply works. I don't know since which version, but I tested the latest
stable version 1.1.15 and it simply works.