Bug 233475 – Adding patches for Lua terminal to sci-visualization/gnuplot to support PGF/TikZ terminal

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Thomas Fischer 2008-07-31 12:44:58 UTC]

There is a patchset and enhancement for gnuplot available to add a new terminal (`lua'). With this terminal, gnuplot can write its output using TikZ commands that can be directly included into a LaTeX document.

The attached ebuild patch adds a new use keyword (`lua') which triggers the ebuild to include the lua terminal code. Current issues are that the lua terminal source package has no version number in it, but the code is supposed to work with both gnuplot 4.2 and 4.3. The dependecy to xetex is due to the usage of the ifxetex.sty package. Maybe dependencies to tetex/TeXlive or pgf/TikZ have to be added.

Reproducible: Always

Steps to Reproduce:

[Comment 1 Thomas Fischer 2008-07-31 12:46:26 UTC]

Created attachment 161835 [details, diff]
Patch adding lua terminal dependency to sci-visualization/gnuplot-4.2.3-r2

[Comment 2 Thomas Fischer 2008-07-31 12:47:27 UTC]

Created attachment 161836 [details, diff]
Patch to add lua support into gnuplot

[Comment 3 Christian Faulhammer (RETIRED) 2008-08-25 08:17:16 UTC]

Is this scheduled for upstream inclusion?  If yes, I happily agree to add it to Gentoo.

[Comment 4 Christoph Junghans (RETIRED) 2009-03-30 19:13:17 UTC]

Tkiz terminal is fantastic.... 
Example see:
http://peter.affenbande.org/gnuplot/gnuplot_lua_terminal/test.pdf

The terminal made it upstream, so please add it to the tree.

----------------------------------
On Peter's Webpage it says:

The terminal is now part of the gnuplot development version on SourceForge. Further development will be done there. Please, don't expect backward compatibility!

The latest terminal revision is 81 (Sun Jan 27 00:00:18 UTC 2008).
The latest script revision is 88 (Sun Nov 23 12:56:33 UTC 2008).

[Comment 5 Ulrich Müller 2009-03-30 19:56:15 UTC]

I'll make a snapshot of gnuplot 4.3 then, that's easier than extracting the lua terminal and adding it to 4.2.5 (which was released today, BTW).

As snapshot of the development version it will be package.masked, though.

[Comment 6 Christoph Junghans (RETIRED) 2009-03-30 20:33:43 UTC]

(In reply to comment #5)
> I'll make a snapshot of gnuplot 4.3 then, that's easier than extracting the lua
> terminal and adding it to 4.2.5 (which was released today, BTW).
Or we try to adapt the patch to 4.2.5. 

I think gnuplot 4.3 will take some time until it is officially released and things are changing too quickly in there.

One the other hand gnuplot 4.3 brings a lot of new features:
http://gnuplot.cvs.sourceforge.net/gnuplot/gnuplot/NEWS?view=markup

Stability vs. Features?

[Comment 7 Ulrich Müller 2009-03-30 20:56:17 UTC]

(In reply to comment #6)
> Or we try to adapt the patch to 4.2.5. 

Yes, we could do that. But probably it's better to extract the Lua terminal from the gnuplot CVS repository, because of licence issues. The standalone tarball is licenced under the GPL which is incompatible with the gnuplot licence. So we would at least need RESTRICT="bindist".

> Stability vs. Features?

That's why the 4.3 snapshot would be package masked. ;-)

[Comment 8 Ulrich Müller 2009-03-31 22:48:55 UTC]

*gnuplot-4.2.5 (31 Mar 2009)

  31 Mar 2009; Ulrich Mueller <[e-mail]>
  +files/gnuplot-gentoo-version.patch, +gnuplot-4.2.5.ebuild:
  Version bump. Add support for PGF/TikZ terminal with USE=lua, bug 233475;
  thanks to Thomas Fischer <[e-mail]>. Add Gentoo version
  identification and contact information, in order to fulfil provisions 2
  through 4 of the gnuplot licence for redistribution of binaries. Remove
  the built_with_use test for media-libs/gd from src_unpack and replace it
  by a USE dependency; therefore bump EAPI to 2. latex_rehash is not needed
  any more, replace it by texmf-update.

Committed to CVS. I've extracted the modifications necessary for the lua terminal from the CVS trunk, and backported them to version 4.2.5. Several other changes to the ebuild, therefore we'll keep it in package.mask for a few days. Please test it!


(In reply to comment #1)
> Created an attachment (id=161835) [edit]
> Patch adding lua terminal dependency to sci-visualization/gnuplot-4.2.3-r2

This adds dev-texlive/texlive-xetex as a dependency which I believe is not necessary. gnuplot-lua-tikz.sty needs only ifxetex.sty, and that is part of texlive-latexrecommended (so latex-base should pull it in).

However, I've added dev-tex/pgf to our dependencies, because it is needed for tikz.sty and xxcolor.sty.

[Comment 9 Christoph Junghans (RETIRED) 2009-04-01 19:06:52 UTC]

Good job, but wxwidgets are not build, when lua is disabled!

See the configure output:

checking for wx-config... /usr/lib/wx/config/gtk2-unicode-release-2.8
checking for CAIROPANGO... configure: WARNING: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Alternatively, you can avoid the need to call pkg-config if you set the
environment variables CAIROPANGO_CFLAGS and CAIROPANGO_LIBS to the
corresponding flags for cairo, pango, and pangocairo.
See the pkg-config man page for more details.

To get pkg-config, see <http://www.freedesktop.org/software/pkgconfig>.

The wxWidgets terminal will not be compiled.

[Comment 10 Christoph Junghans (RETIRED) 2009-04-01 19:11:10 UTC]

Created attachment 187009 [details, diff]
Patch from upstram to fix the first call of PKG_PROG_PKG_CONFIG

Fixed the issue when building with USE="wxwindows -lua"

[Comment 11 Christoph Junghans (RETIRED) 2009-04-01 19:15:08 UTC]

Created attachment 187011 [details, diff]
Patch for gnuplot-4.2.5.ebuild

-Applies PKG_PROG_PKG_CONFIG.patch
-Uses flag-o-matic

[Comment 12 Ulrich Müller 2009-04-01 20:28:08 UTC]

(In reply to comment #9)
> Good job, but wxwidgets are not build, when lua is disabled!

Well spotted. Thanks for locating the right patch.

(In reply to comment #11)
> -Uses flag-o-matic

flag-o-matic.eclass should be used when removing or replacing flags. For adding them it's overkill (and blowing up the environment).


(In reply to comment #8)
> This adds dev-texlive/texlive-xetex as a dependency which I believe is not
> necessary. gnuplot-lua-tikz.sty needs only ifxetex.sty, and that is part of
> texlive-latexrecommended (so latex-base should pull it in).

Actually, it's more complicated, because the ifxetex module was moved from tl-xetex to tl-latexrecommended in 2008. So the correct dependency is:
    || ( >=dev-texlive/texlive-latexrecommended-2008-r2
         =dev-texlive/texlive-xetex-2007* )

[Comment 13 Christoph Junghans (RETIRED) 2009-04-04 13:53:02 UTC]

The install works for me, now let's give it some testing.

I filed a bug upstream concerning to the install place of 
gnuplot-lua-tikz.sty (and some other bug with the lua terminal):

http://sourceforge.net/tracker/?func=detail&aid=2726895&group_id=2055&atid=102055

[Comment 14 Ulrich Müller 2009-04-05 19:19:13 UTC]

Unmasked gnuplot-4.2.5, so that it will get some ~arch testing.
Thanks everyone.