Bug 233099

Summary:	media-gfx/pngcrush-1.6.4-r1 parses wrong gas-version in Makefile
Product:	Gentoo Linux	Reporter:	Martin Väth <martin>
Component:	Current packages	Assignee:	Gentoo Graphics Project <graphics+disabled>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Calculate gas version properly

Description Martin Väth 2008-07-27 11:52:43 UTC

The debian patch of pngcrush uses bad sh-code to parse the gas-version.
Not only does it fail when /bin/sh is a symlink to dash
(so that emerge will not work in this case), but I guess even with bash
it will pass the wrong version (although I have not tried the latter).

I attach a patch which should be applied after the current src_unpack

Comment 1 Martin Väth 2008-07-27 11:54:58 UTC

Created attachment 161459 [details, diff]
Calculate gas version properly

The patch not only fixes the version parsing but also avoids a redundant grep.
Note that it must be applied after the other patches.

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2008-07-29 14:03:23 UTC

Thanks.. I'll will check that this is OK for next version, 1.6.7 which seems to be out. Today, hopefully.

Comment 3 Samuli Suominen (RETIRED) gentoo-dev

2008-07-30 20:08:24 UTC

pngcrush-1.6.7 fixes this minor issue, i don't think it qualifies as a reason to get it stable immediately.. let's just wait the default 30 days

thanks for reporting