Bug 232418 - media-plugins/audacious-plugins-1.5.1 fails to build on 64bits arches.
Bug#: 232418 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: chainsaw@gentoo.org Reported By: aballier@gentoo.org
Component: Applications
URL: 
Summary: media-plugins/audacious-plugins-1.5.1 fails to build on 64bits arches.
Keywords:  
Status Whiteboard: 
Opened: 2008-07-20 09:48 0000
Description:   Opened: 2008-07-20 09:48 0000 
Similar to bug #216848


 * QA Notice: Package has poor programming practices which may compile
 *            but will almost certainly crash on 64bit architectures.
 * Function `audacious_get_localdir' implicitly converted to pointer at
i_configure.c:419

 * 
 * ERROR: media-plugins/audacious-plugins-1.5.1 failed.
 * Call stack:
 *       misc-functions.sh, line 653:  Called install_qa_check
 *       misc-functions.sh, line 349:  Called die
 * The specific snippet of code:
 *                             
alpha*|ia64*|powerpc64*|mips64*|sparc64*|x86_64*) die "this code is not 64bit
clean";;
 *  The die message:
 *   this code is not 64bit clean



Probably missing #include <audacious/plugin.h>
that means the default return value of the function will be int, while it's
casted to gchar*

------- Comment #1 From Ivan Iraci 2008-07-22 13:02:46 0000 ------- 
(In reply to comment #0)
Same here.

------- Comment #2 From Ivan Iraci 2008-07-22 13:15:34 0000 ------- 
Created an attachment (id=161095) [details]
Patch that fixes the bug

------- Comment #3 From Tony Vroon 2008-07-22 13:29:04 0000 ------- 
Thank you Ivan, patch committed upstream:
<CIA-1> audacious-plugins: Tony Vroon <chainsaw@gentoo.org> default *
2843:29a14d80fcd8 /src/amidi-plug/i_configure.c: Patch by ivanhoe@vfemail.net
to include missing header, resolves QA warning and Gentoo bug #232418.

------- Comment #4 From Tony Vroon 2008-07-22 14:15:42 0000 ------- 
Ivan, your contribution to the Audacious project & Gentoo linux is highly
appreciated. This is in the tree as 1.5.1-r1.

------- Comment #5 From Ivan Iraci 2008-07-22 14:25:19 0000 ------- 
(In reply to comment #4)
It was a pleasure to contribute. Thanks to you all for your efforts.