Bug 231599 - HTML docs installed twice by media-gfx/qtpfsgui-1.9.2-r1
Bug#: 231599 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: trivial Priority: P2
Resolution: FIXED Assigned To: graphics@gentoo.org Reported By: pgaal@gmx.net
Component: Ebuilds
URL: 
Summary: HTML docs installed twice by media-gfx/qtpfsgui-1.9.2-r1
Keywords:  
Status Whiteboard: 
Opened: 2008-07-12 15:38 0000
Description:   Opened: 2008-07-12 15:38 0000 
The aforesaid ebuild makes use of the use flag "doc" now. But in doing so, it
installs the whole HTML documentation twice.

------- Comment #1 From Peter GAAL 2008-07-12 15:44:37 0000 ------- 
Created an attachment (id=160200) [details]
Minor improvements for qtpfsgui-1.9.2-r1.ebuild

This patch prevents qmake from installing the docs into the program's own
directory. Furthermore, it removes unused locales. The icon's location is also
changed to Gnome's standard location (on my system at least).

------- Comment #2 From Markus Meier 2008-08-11 04:41:05 0000 ------- 
thanks for the report and patch, I've committed a modified version to
media-gfx/qtpfsgui-1.9.2-r1.

------- Comment #3 From Peter GAAL 2009-01-16 18:29:38 0000 ------- 
Created an attachment (id=178707) [details]
Ebuild patch needed to activate the corrected help

Oops, the menu Help -> Documentation doesn't work any more.

------- Comment #4 From Peter GAAL 2009-01-16 18:32:05 0000 ------- 
Created an attachment (id=178708) [details]
Help patch

As the documentation path is hard-coded into the source, we need to patch it
too.

------- Comment #5 From Peter GAAL 2009-01-16 18:34:56 0000 ------- 
(In reply to comment #3)

The patch is necessary to make the documentation accessible from inside the
program.

------- Comment #6 From Markus Meier 2009-01-17 12:29:22 0000 ------- 
thanks for the hint, I "solved" this a bit different by removing the html build
target out of the qt-project file, when the doc useflag is not set. so we don't
have to touch the sourcecode...

------- Comment #7 From Peter GAAL 2009-01-17 19:54:42 0000 ------- 
(In reply to comment #6)

Sorry to insist, but we have to: it is the other way round.

Basically, we had moved the documentation from /usr/share/qtpfsgui/ to its
standard location in /usr/share/doc by using dohtml. When the doc use flag is
unset, it is OK to see an empty assistant window as there is no documentation
installed at all.

But if someone sets the doc flag, he might reasonably expect the documentation
at its place, i.e. in the help menu. And for this purpose, the program must be
aware of the new path somehow.

------- Comment #8 From Markus Meier 2009-02-14 22:14:58 0000 ------- 
doc useflag removed, as the previous situation was suboptimal.

  14 Feb 2009; Markus Meier <maekke@gentoo.org> qtpfsgui-1.9.2-r1.ebuild:
  remove useless doc USE-flag, assign RDEPEND