Ebuild looks good to me. Maybe add GPL-2 to LICENSE, since it's in the header
of noweb-mode.el?
Emacs site-init file: Since noweb-mode is a minor mode, the "autoload" line
should read:
(autoload 'noweb-mode "noweb-mode" "Minor meta mode for editing noweb files."
t)
(In reply to comment #3)
> Ebuild looks good to me. Maybe add GPL-2 to LICENSE, since it's in the header
> of noweb-mode.el?
>
> Emacs site-init file: Since noweb-mode is a minor mode, the "autoload" line
> should read:
> (autoload 'noweb-mode "noweb-mode" "Minor meta mode for editing noweb files."
> t)
please feel free to apply if you're happy with it and it just adds emacs
support ;)
I don't use emacs myself and have no clue how these modes work so I'd be rather
useless there :/
I'll also add some quotes around $(tc-getCC) because I get the following build
failure:
>>> Compiling source in /var/tmp/portage/app-text/noweb-2.11b/work/noweb-2.11b/src ...
make: invalid option -- 'O'
Usage: make [options] [target] ...
Options:
-b, -m Ignored for compatibility.
-B, --always-make Unconditionally make all targets.
-C DIRECTORY, --directory=DIRECTORY
Change to DIRECTORY before doing anything.
-d Print lots of debugging information.
--debug[=FLAGS] Print various types of debugging information.
-e, --environment-overrides
Environment variables override makefiles.
-f FILE, --file=FILE, --makefile=FILE
Read FILE as a makefile.
-h, --help Print this message and exit.
-i, --ignore-errors Ignore errors from commands.
-I DIRECTORY, --include-dir=DIRECTORY
Search DIRECTORY for included makefiles.
-j [N], --jobs[=N] Allow N jobs at once; infinite jobs with no arg.
-k, --keep-going Keep going when some targets can't be made.
-l [N], --load-average[=N], --max-load[=N]
Don't start multiple jobs unless load is below N.
-L, --check-symlink-times Use the latest mtime between symlinks and target.
-n, --just-print, --dry-run, --recon
Don't actually run any commands; just print them.
-o FILE, --old-file=FILE, --assume-old=FILE
Consider FILE to be very old and don't remake it.
-p, --print-data-base Print make's internal database.
-q, --question Run no commands; exit status says if up to date.
-r, --no-builtin-rules Disable the built-in implicit rules.
-R, --no-builtin-variables Disable the built-in variable settings.
-s, --silent, --quiet Don't echo commands.
-S, --no-keep-going, --stop
Turns off -k.
-t, --touch Touch targets instead of remaking them.
-v, --version Print the version number of make and exit.
-w, --print-directory Print the current directory.
--no-print-directory Turn off -w, even if it was turned on implicitly.
-W FILE, --what-if=FILE, --new-file=FILE, --assume-new=FILE
Consider FILE to be infinitely new.
--warn-undefined-variables Warn when an undefined variable is referenced.
This program built for i686-pc-linux-gnu
Report bugs to <bug-make@gnu.org>
*
* ERROR: app-text/noweb-2.11b failed.
* Call stack:
* ebuild.sh, line 49: Called src_compile
* environment, line 2293: Called die
* The specific snippet of code:
* emake ICONC="icont" CC=$(tc-getCC) CFLAGS="${CFLAGS}" LIBSRC="icon" )
|| die;
* The die message:
* (no error message)
