Bug 228725

Summary:	[PATCH] app-arch/lzma-utils-4.32.5 and app-arch/lzma-utils-4.32.6 do not compile with -pedantic
Product:	Gentoo Linux	Reporter:	Nico R. <n-roeser>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	esigra
Priority:	Lowest
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to remove an extra semicolon from lzma-4.32.6.

Description Nico R. 2008-06-21 12:34:20 UTC

In app-arch/lzma-utils-4.32.5 and app-arch/lzma-utils-4.32.6, there is an extra semicolon after the closing brace in src/sdk/7zip/Compress/LZMA/LZMAEncoder.cpp, line 185. This is not valid ISO C++, as far as I know.

After removing the extra semicolon, the code compiles with ‘-pedantic’ in CXXFLAGS.

Comment 1 Nico R. 2008-06-21 12:36:46 UTC

Created attachment 157899 [details, diff]
Patch to remove an extra semicolon from lzma-4.32.6.

Code compiles with gcc-4.3.1 with -pedantic after using this patch.

Comment 2 SpanKY gentoo-dev

2008-06-22 01:17:50 UTC

source code correctness (-pedantic) is not something we care about ... these kind of things go upstream

upstream has already fixed this though and the patch is trivial, so i'll add it