Bug 226893 - games-action/snipes: append-ldflags is used to pass libraries
Bug#: 226893 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: flameeyes@gentoo.org
Component: Games
URL: 
Summary: games-action/snipes: append-ldflags is used to pass libraries
Keywords:  
Status Whiteboard: 
Opened: 2008-06-14 18:14 0000
Description:   Opened: 2008-06-14 18:14 0000 
I've made append-ldflags throw a warning when libraries are passed through it
to link them in.

The reason is that LDFLAGS should _not_ be used for libraries, as it has to be
positioned before the list of objects to link together, while libraries should
go after.

This mistake in commandline is what causes as-needed to either fail or not
apply at all (if LDFLAGS are put at the end).

Please fix your package not to pass libraries through LDFLAGS.

------- Comment #1 From Cyp 2008-07-05 15:06:57 0000 ------- 
Created an attachment (id=159632) [details]
Ebuild without append-ldflags

I've removed append-ldflags from the ebuild.

The biggest difference between 1.0.1 and 1.0.2 is that 1.0.2 has a Makefile.
Some unused variables and unused functions have been deleted. The code should
behave the same.

------- Comment #2 From Tristan Heaven 2008-09-04 21:05:09 0000 ------- 
Fixed, thanks.