Bug 226685 - app-editors/nvi-1.81.6 stable request -- 1.81.5 patch (nvi-1.81.5-build.patch) changes both autotools source and result
|
Bug#:
226685
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: normal
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: truedfx@gentoo.org
|
Reported By: flameeyes@gentoo.org
|
|
Component: Ebuilds
|
|
|
URL:
|
|
Summary: app-editors/nvi-1.81.6 stable request -- 1.81.5 patch (nvi-1.81.5-build.patch) changes both autotools source and result
|
|
Keywords: STABLEREQ
|
|
Status Whiteboard:
|
|
Opened: 2008-06-14 15:58 0000
|
The patch in summary is touching both Makefile.in and Makefile.am, probably to
avoid autotools rebuild.
This treatment is usually reserved for a few selected system packages that
cannot have their autotool scripts rebuilt.
This _could_ cause maintainermode-driven rebuild (see
http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is
something we should be avoiding as much as possible.
Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools,
unless you have very good reasons not to.
Yes, I was touching Makefile.am precisely to avoid the re-running of autotools
during make. I did not want to re-run autotools, either during make or from the
ebuild, because it would fail. The configure.ac was written for autoconf 2.13,
but several macros it used no longer supported autoconf 2.13, so either I
needed to patch up configure.ac, which was something I didn't know how to do,
or I needed to make nvi depend on outdated system packages to get the old
versions of the macros. I picked
Yes, I was touching Makefile.am precisely to avoid the re-running of autotools
during make. I did not want to re-run autotools, either during make or from the
ebuild, because it would fail. The configure.ac was written for autoconf 2.13,
but several macros it used no longer supported autoconf 2.13, so either I
needed to patch up configure.ac, which was something I didn't know how to do,
or I needed to make nvi depend on outdated system packages to get the old
versions of the macros. I picked the current way as the least evil.
nvi 1.81.6 no longer needs the patch, so I think there's nothing that really
_needs_ fixing here, but if you prefer, I don't have any objections to seeing
that stabilised and the old version removed. What would you like?
Sorry for the bugspam, I'm not entirely used to konqueror's access keys. Too
easy to click Commit just by typing. :)
Marking the new one stable and getting rid of the patch seems the perfect
solution to me ;)
Alrighty then. Arch teams, would you please test and stabilise
app-editors/nvi-1.81.6, so that the older versions can be removed?
Compiles, merges and runs fine on amd64.
$ emerge --info
Portage 2.1.4.4 (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.6.1-r0,
2.6.25-tuxonice-r4 x86_64)
=================================================================
System uname: 2.6.25-tuxonice-r4 x86_64 Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz
Timestamp of tree: Mon, 16 Jun 2008 19:45:02 +0000
app-shells/bash: 3.2_p33
dev-lang/python: 2.5.2-r4
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox: 1.2.18.1-r2
sys-devel/autoconf: 2.13, 2.61-r1
sys-devel/automake: 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils: 2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool: 1.5.26
virtual/os-headers: 2.6.23-r3
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/fonts/fonts.conf /etc/gconf
/etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="collision-protect distlocks metadata-transfer multilib-strict
parallel-fetch sandbox sfperms strict test unmerge-orphans userfetch"
GENTOO_MIRRORS="http://gentoo.virginmedia.com
ftp://mirrors.virginmedia.com/mirrors/gentoo"
LANG="en_GB.UTF-8"
LINGUAS="en en_GB uk"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --stats --timeout=180 --exclude=/distfiles
--exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp/tmpfs"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/pulsewidth-overlay"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X acpi alsa amd64 bash-completion caps cli cracklib crypt dbus dri dvd
exif gpm gtk gtkhtml hal iconv imap ipv6 isdnlog jpeg libnotify libsexy mad
midi mmx mp3 mudflap mysql ncurses nls nptl nptlonly opengl openmp pam pcre png
pppd qt4 readline reflection ruby session smp spell spl sse sse2 ssl
startup-notification tcpd truetype unicode vim-syntax x264 xinerama xorg
xscreensaver xv xvid xvmc zlib" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix
dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter
mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions
alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file
authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user
autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires
ext_filter file_cache filter headers include info log_config logio mem_cache
mime mime_magic negotiation rewrite setenvif speling status unique_id userdir
usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse"
KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001
mtxorb ncurses text" LINGUAS="en en_GB uk" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS,
PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
mips won't mark anything stable