Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 225117

Summary: x11-misc/qterm-0.5.2 failed to compile with -Wl,--as-needed (patch supplied)
Product: Gentoo Linux Reporter: Zhang Le (RETIRED) <r0bertz>
Component: Current packagesAssignee: CJK Team <cjk>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard: patch waiting review
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 129413    
Attachments: qterm-0.5.2-as-needed.patch
new qterm-0.5.2.ebuild
fixed qterm-0.5.2.ebuild
new qterm-0.5.2-as-needed.patch

Description Zhang Le (RETIRED) gentoo-dev 2008-06-06 14:03:03 UTC
qterm-0.5.2 failed to compile with -Wl,--as-needed (patch supplied)
Comment 1 Zhang Le (RETIRED) gentoo-dev 2008-06-06 14:11:52 UTC
Created attachment 155717 [details, diff]
qterm-0.5.2-as-needed.patch
Comment 2 Zhang Le (RETIRED) gentoo-dev 2008-06-06 14:15:43 UTC
Created attachment 155719 [details]
new qterm-0.5.2.ebuild

new ebuild, applied the patch
also I have removed IUSE="ssl" since openssl is actually required unconditionally.
Comment 3 Zhang Le (RETIRED) gentoo-dev 2008-06-06 14:43:46 UTC
Please hold on, FindPkgConfig module does not exist in low version cmake.
Comment 4 Zhang Le (RETIRED) gentoo-dev 2008-06-06 15:03:58 UTC
Created attachment 155727 [details]
fixed qterm-0.5.2.ebuild

This one added eutils eclass and set min cmake version to 2.4.7
Comment 5 Zhang Le (RETIRED) gentoo-dev 2008-06-06 16:32:40 UTC
Heard from upstream author that openssl is actually not required
So I will modified the patch.
Also new cmake already has FindOpenSSL module.
However it will not solve the as-needed proble.
So we still need this patch for the time being.
Comment 6 Zhang Le (RETIRED) gentoo-dev 2008-06-06 17:09:09 UTC
Created attachment 155737 [details, diff]
new qterm-0.5.2-as-needed.patch

removed "REQUIRED" argument of pkg_search_module
Comment 7 Zhang Le (RETIRED) gentoo-dev 2008-06-06 17:18:53 UTC
(In reply to comment #5)
> Also new cmake already has FindOpenSSL module.
> However it will not solve the as-needed proble.

http://public.kitware.com/Bug/view.php?id=7172
Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-02 11:29:37 UTC
This should be fixed in tree already.