Bug 224833 - gentoo-x86/eclass/rox.eclass:297: - python_mod_optimize should only be run in pkg_postinst()
Bug#: 224833 Product:  Gentoo Linux Version: unspecified Platform: AMD64
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: rox@gentoo.org Reported By: nils@nils-andresen.de
Component: Ebuilds
URL: 
Summary: gentoo-x86/eclass/rox.eclass:297: - python_mod_optimize should only be run in pkg_postinst()
Keywords:  
Status Whiteboard: 
Opened: 2008-06-04 04:49 0000
Description:   Opened: 2008-06-04 04:49 0000
Building rox-base/mime-editor-0.5-r2 (or -r1) fails with:

RROR: rox-base/mime-editor-0.5-r2 failed.
Call stack:
              ebuild.sh, line   49:  Called src_install
            environment, line 2987:  Called rox-0install_src_install
            environment, line 2790:  Called rox_src_install
            environment, line 2950:  Called python_mod_optimize 'src_install'
            environment, line 2723:  Called die
The specific snippet of code:
      [[ ${EBUILD_PHASE} != postinst ]] && die "${FUNCNAME} should only be run
in pkg_postinst()";
 The die message:
  python_mod_optimize should only be run in pkg_postinst()

The Problem would be the rox.eclass:
It calls python_mod_optimize as the last line of rox_src_install().
Afer movin the Line into rox_pkg_postinst() all is fine !


Reproducible: Always

------- Comment #1 From Jeroen Roovers 2008-06-04 04:57:59 0000 -------
A bit of automated QA it seems.

------- Comment #2 From Jim Ramsay 2008-06-04 12:28:50 0000 -------
I guess so!

What's really odd is that I couldn't ever get a straight answer out of the
python folks as to why python_mod_optimize should be run in pkg_postinst and
not src_install.

Oh well, moot point now, I'll just have to fix everything.

------- Comment #3 From Jim Ramsay 2008-06-04 12:38:54 0000 -------
Okay, all changed (as far as I know, anyway)

Would have been nice had they mentioned somewhere they were going to start
cracking down on this instead of breaking the tree, but there you go.

------- Comment #4 From Jim Ramsay 2008-06-04 13:07:40 0000 -------
Heh, turns out they did and I missed it, I rescind my previous slander :)