Bug 220761 - revdep-rebuild: Speedup by not assigning the same file several times
Bug#: 220761 Product:  Portage Development Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: tools-portage@gentoo.org Reported By: hanno@gentoo.org
Component: Tools
URL: 
Summary: revdep-rebuild: Speedup by not assigning the same file several times
Keywords:  InSVN
Status Whiteboard: 
Opened: 2008-05-07 14:21 0000
Description:   Opened: 2008-05-07 14:21 0000 
If several breakages occur on one file (e.g. on .la files), revdep-rebuild
wants to assign it to a package several times, which heavily slows it down.
Looks like this:

 * Assigning files to packages
 *   /usr/kde/3.5/lib/kde3/ark.la -> kde-base/ark
 *   /usr/kde/3.5/lib/kde3/ark.la -> kde-base/ark
 *   /usr/kde/3.5/lib/kde3/ark.la -> kde-base/ark
[...]

Between step 3 and 4, one could just insert a sort|uniq to avoid this. I've
written a fast and ugly patch for it.

------- Comment #1 From Hanno Boeck 2008-05-07 14:22:06 0000 ------- 
Created an attachment (id=152281) [details]
speedup revdep-rebuild by doing sort|uniq between step 3 and 4

------- Comment #2 From Paul Varner 2008-07-09 19:01:24 0000 ------- 
$ svn commit -m "Fix revdep-rebuild to not evaluate broken objects multiple
times. (Bug 220761)" ChangeLog src/revdep-rebuild/revdep-rebuild
Sending        ChangeLog
Sending        src/revdep-rebuild/revdep-rebuild
Transmitting file data ..
Committed revision 493.

------- Comment #3 From Paul Varner 2008-07-10 16:47:41 0000 ------- 
Released in gentoolkit-0.2.4_rc5.