Summary: | app-portage/elogviewer-0.5.2-r1: CTRL-C purges elog directory without warning | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | James Blanding <ilikepi> |
Component: | [OLD] Unspecified | Assignee: | Portage Tools Team <tools-portage> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | fauli |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | patch to add warning dialog |
Description
James Blanding
2008-04-23 04:13:01 UTC
(In reply to comment #0) > Pressing Control-C with elogviewer in the foreground deletes all files in > /var/log/portage/elog/ without prompting or warning. I am inclined to close this as INVALID (see reasoning below), but maybe will hack a warning into elogviewer. > Expected Results: > Since Control-C is not a supported keybinding in elogviewer, it should either > be ignored or trapped. It is. If you open the file menu you will find that "Clear" is bound to Ctrl-C. (In reply to comment #1) > (In reply to comment #0) > > Pressing Control-C with elogviewer in the foreground deletes all files in > > /var/log/portage/elog/ without prompting or warning. > > I am inclined to close this as INVALID (see reasoning below), but maybe will > hack a warning into elogviewer. > > > Expected Results: > > Since Control-C is not a supported keybinding in elogviewer, it should either > > be ignored or trapped. > > It is. If you open the file menu you will find that "Clear" is bound to > Ctrl-C. > Doh...well I feel like an dolt now. Sorry about that. I ran into this issue because I highlighted some text in the details display frame and habitually pressed Control-C to copy it, forgetting about the X11 clipboard. I think it would be a useful enhancement to have a warning displayed. Changed to Enhancement; request for warning prompt when using Clear function. Created attachment 150891 [details, diff]
patch to add warning dialog
In a pitiful attempt to redeem myself, I figured I'd try my hand at submitting a patch to add a warning dialog. Perhaps at best, doing this poorly will motivate someone else to do it properly. :D FWIW, I've never written Python before, and pygtk.org is down (saved by Google Cache), but I did my best anyway. Please be gentle...
(In reply to comment #4) > In a pitiful attempt to redeem myself, I figured I'd try my hand at submitting > a patch to add a warning dialog. Perhaps at best, doing this poorly will > motivate someone else to do it properly. :D FWIW, I've never written Python > before, and pygtk.org is down (saved by Google Cache), but I did my best > anyway. Please be gentle... Thanks a lot, the patch looks ok from my point of view. I was looking into it but you saved me some time as I am not that Python skilled. Choosing Ctrl-C as a short cut for a clear function is not the best solution. :) Committed to the tree and closing this bug. Stabilisation in 30 days. |