Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 217510

Summary: net-irc/quassel ebuild enhancements
Product: Gentoo Linux Reporter: Alan Jones <skyphyr>
Component: New packagesAssignee: Diego Elio Pettenò (RETIRED) <flameeyes>
Status: RESOLVED FIXED    
Severity: enhancement CC: billie, net-irc
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: The main ebuild file
the init.d/quasselcore file
the conf.d/quasselcore file
quassel-9999-r1.diff
quassel-0.2.9999.diff
quassel-0.2.0_rc1.diff
quasselcore.conf
quasselcore.init
quassel-9999-r1.diff
quassel-0.2.0_rc1.diff
quassel-0.2.9999.diff
quassel-9999-r1.diff
quasselcore.conf
quasselcore.init
quasselcore.init

Description Alan Jones 2008-04-13 12:45:29 UTC
For server adds an init script, sets up an unprivileged user to run quasselcore as. For X adds doicon and domenu.

Hope this helps.

Cheers,

Alan.

Reproducible: Always
Comment 1 Alan Jones 2008-04-13 12:45:52 UTC
Created attachment 149551 [details]
The main ebuild file
Comment 2 Alan Jones 2008-04-13 12:46:13 UTC
Created attachment 149552 [details]
the init.d/quasselcore file
Comment 3 Alan Jones 2008-04-13 12:46:29 UTC
Created attachment 149553 [details]
the conf.d/quasselcore file
Comment 4 Ingmar Vanhassel (RETIRED) gentoo-dev 2008-04-13 12:59:37 UTC
(In reply to comment #1)
> Created an attachment (id=149551) [edit]
> The main ebuild file

Attach patches in unified diff format please.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-04-13 13:06:01 UTC
doicon is simply wrong to use in every case, as it does not put the icon in the proper icon theme directory. the desktop file is broken, it should be corrected before it can be installed.

The script is not good, both from a technical standpoint (doesn't create a pid file to begin with) nor from a less technical one (missing GPL header, can't use it).

For what concerns icon and desktop file, I'll see to talk with Sput and add those for 9999 (and next alpha), for the init file, I had something locally already but I haven't been able to work on it much lately.
Comment 6 Daniel Pielmeier gentoo-dev 2008-08-04 23:14:44 UTC
Another try for using an init script with quasselcore.

It follows:
quassel-9999-r1.diff
Changed dependencies to qt-4.4. Not sure if I have done this right though.

quassel-0.2.9999.diff
quassel-0.2.0_rc1.diff

In all of the above I have changed the position of inherit git, because 0.2.9999 tries to install the master branch like 9999-r1 because inherit.git is set before EGIT_BRANCH.


quasselcore.conf
quasselcore.init

The init script creates a pidfile and has an appropriate header now :-)
The user has to set his user name in quasselcore.conf so quassel uses the users homedir for configuration files.
Comment 7 Daniel Pielmeier gentoo-dev 2008-08-04 23:15:34 UTC
Created attachment 162226 [details, diff]
quassel-9999-r1.diff
Comment 8 Daniel Pielmeier gentoo-dev 2008-08-04 23:15:56 UTC
Created attachment 162228 [details, diff]
quassel-0.2.9999.diff
Comment 9 Daniel Pielmeier gentoo-dev 2008-08-04 23:16:21 UTC
Created attachment 162230 [details, diff]
quassel-0.2.0_rc1.diff
Comment 10 Daniel Pielmeier gentoo-dev 2008-08-04 23:16:55 UTC
Created attachment 162231 [details]
quasselcore.conf
Comment 11 Daniel Pielmeier gentoo-dev 2008-08-04 23:17:11 UTC
Created attachment 162233 [details]
quasselcore.init
Comment 12 Daniel Pielmeier gentoo-dev 2008-08-06 20:13:33 UTC
Created attachment 162391 [details, diff]
quassel-9999-r1.diff

There is no 4.4 splot!
Comment 13 Daniel Pielmeier gentoo-dev 2008-08-10 20:28:46 UTC
Created attachment 162640 [details, diff]
quassel-0.2.0_rc1.diff

minor changes
Comment 14 Daniel Pielmeier gentoo-dev 2008-08-10 20:29:18 UTC
Created attachment 162641 [details, diff]
quassel-0.2.9999.diff

minor changes
Comment 15 Daniel Pielmeier gentoo-dev 2008-08-10 20:29:43 UTC
Created attachment 162643 [details, diff]
quassel-9999-r1.diff

minor changes
Comment 16 Daniel Pielmeier gentoo-dev 2008-08-10 20:30:05 UTC
Created attachment 162644 [details, diff]
quasselcore.conf

minor changes
Comment 17 Daniel Pielmeier gentoo-dev 2008-08-10 20:30:33 UTC
Created attachment 162646 [details, diff]
quasselcore.init

minor changes
Comment 18 Daniel Pielmeier gentoo-dev 2008-08-10 20:32:49 UTC
Just a sidenote.

The init script does not work with the current master repo in quassel-9999-r1. When --make-pidfile and --pidfile are removed it works as expected, but without a pidfile!
Comment 19 Daniel Pielmeier gentoo-dev 2008-08-10 21:16:55 UTC
Created attachment 162650 [details, diff]
quasselcore.init

--make-pidfile does not need an argument. Now the script works again
Comment 20 Markus Ullmann (RETIRED) gentoo-dev 2008-08-26 12:02:27 UTC
Stuff added to CVS, thanks for the contributions, keep up the good work :)