Bug 217326 - Suggestion: Make horde modules depend on either horde, horde-groupware or horde-webmail
Bug#: 217326 Product:  Gentoo Linux Version: 2007.0 Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: vapier@gentoo.org Reported By: robin.bankhead@gmail.com
Component: Server
URL: 
Summary: Suggestion: Make horde modules depend on either horde, horde-groupware or horde-webmail
Keywords:  
Status Whiteboard: 
Opened: 2008-04-11 18:49 0000
Description:   Opened: 2008-04-11 18:49 0000
I would like to suggest that individual horde modules depend on one of horde,
horde-webmail or horde-groupware.

Reason: currently, modules that are not included in horde-webmail or
horde-groupware cannot be emerged if the respective package is installed,
because they depend on horde, which is blocked by these "combined" packages.

Example: horde-webmail does not include horde-mimp, but it's quite feasible
that one might want to emerge this too. Not possible, because of the block. 

To preserve the necessary aspect of preventing individual modules being emerged
when one of the combi packages that includes them is already merged, make the
combi package(s) block that module, or make them depend on horde only (as is
currently true).

If this change is agreed in principle, I will be happy to compile a list of
what would need changed for which packages.

------- Comment #1 From SpanKY 2008-04-12 21:27:36 0000 -------
idea sounds sane enough ... if you want to post patches, that'd be good

------- Comment #2 From Robin Bankhead 2008-04-13 09:29:36 0000 -------
I'll give it a go, will need to learn how first though ;)

Here's that list:

1) blocks
- www-apps/horde blocks www-apps/horde-groupware, www-apps/horde-webmail
- www-apps/horde-groupware blocks www-apps/horde, www-apps/horde-webmail
- www-apps/horde-webmail blocks www-apps/horde, www-apps/horde-groupware

2) depends
- www-apps/horde-chora depends on www-apps/horde OR www-apps/horde-groupware OR
www-apps/horde-webmail
- www-apps/horde-gollem depends on www-apps/horde OR www-apps/horde-groupware
OR www-apps/horde-webmail
- www-apps/horde-imp depends on www-apps/horde OR www-apps/horde-groupware
- www-apps/horde-ingo depends on www-apps/horde OR www-apps/horde-groupware
- www-apps/horde-jeta depends on www-apps/horde OR www-apps/horde-groupware OR
www-apps/horde-webmail
- www-apps/horde-kronolith depends on www-apps/horde
- www-apps/horde-mimp depends on www-apps/horde OR www-apps/horde-groupware OR
www-apps/horde-webmail
- www-apps/horde-mnemo depends on www-apps/horde
- www-apps/horde-nag depends on www-apps/horde
- www-apps/horde-passwd depends on www-apps/horde OR www-apps/horde-groupware
OR www-apps/horde-webmail
- www-apps/horde-turba depends on www-apps/horde

I'll see what I can do with these.

------- Comment #3 From Robin Bankhead 2008-04-13 15:48:26 0000 -------
Created an attachment (id=149564) [details]
patch for horde-chora-2.0.2.ebuild

Hope I have got these in appropriate format... six more to come.

------- Comment #4 From Robin Bankhead 2008-04-13 15:49:28 0000 -------
Created an attachment (id=149566) [details]
patch to horde-gollem-1.0.3.ebuild

------- Comment #5 From Robin Bankhead 2008-04-13 15:50:05 0000 -------
Created an attachment (id=149568) [details]
patch to horde-imp-4.1.6.ebuild

------- Comment #6 From Robin Bankhead 2008-04-13 15:50:38 0000 -------
Created an attachment (id=149570) [details]
patch to horde-ingo-1.1.5.ebuild

------- Comment #7 From Robin Bankhead 2008-04-13 15:51:15 0000 -------
Created an attachment (id=149571) [details]
patch to horde-jeta-1.0.ebuild

------- Comment #8 From Robin Bankhead 2008-04-13 15:52:05 0000 -------
Created an attachment (id=149572) [details]
patch to horde-mimp-1.0.2.ebuild

------- Comment #9 From Robin Bankhead 2008-04-13 15:52:57 0000 -------
Created an attachment (id=149574) [details]
patch to horde-passwd-3.0.1.ebuild

------- Comment #10 From SpanKY 2008-04-14 00:37:02 0000 -------
in the future, make sure you create unified style diffs, not context style

the changes all look fine, just one quick question before i merge them ...
think we should have horde blocking the groupware/webmail packages ?  or just
leave them alone since they install into non-conflicting directories ?

------- Comment #11 From Robin Bankhead 2008-04-14 00:59:28 0000 -------
I would think all three should block each other, to avoid redundancy. The only
f'rinstance I can think of to support not doing so is having a range of
different vhosts that you wanted to construct various combinations on. In such
an instance, though, I would think you'd just be better off choosing all
separate packages rather than the meta-packages.

------- Comment #12 From Robin Bankhead 2008-05-19 19:43:22 0000 -------
Is there anything else I need to do re: this?

------- Comment #13 From SpanKY 2008-05-31 05:14:00 0000 -------
nope ... it's just a pain to merge patches that arent in unidiff format as they
have to all be done by hand

should be all set in cvs now though, thanks for the patches

http://sources.gentoo.org/www-apps/horde-chora/horde-chora-2.0.2.ebuild?r1=1.3&r2=1.4
http://sources.gentoo.org/www-apps/horde-gollem/horde-gollem-1.0.3.ebuild?r1=1.1&r2=1.2
http://sources.gentoo.org/www-apps/horde-imp/horde-imp-4.1.6.ebuild?r1=1.6&r2=1.7
http://sources.gentoo.org/www-apps/horde-ingo/horde-ingo-1.1.5.ebuild?r1=1.1&r2=1.2
http://sources.gentoo.org/www-apps/horde-jeta/horde-jeta-1.0.ebuild?r1=1.1&r2=1.2
http://sources.gentoo.org/www-apps/horde-mimp/horde-mimp-1.0.2.ebuild?r1=1.1&r2=1.2
http://sources.gentoo.org/www-apps/horde-passwd/horde-passwd-3.0.1.ebuild?r1=1.2&r2=1.3