Summary: | gnome-base/control-center-2.20.3: patch for adding some options to gnome-default-applications-properties | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Pacho Ramos <pacho> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
control-center-gentoo.patch (for 2.20)
control-center-2.22.0-more_apps.patch |
Description
Pacho Ramos
2008-03-29 13:00:12 UTC
Created attachment 147623 [details, diff]
control-center-gentoo.patch (for 2.20)
sounds nice to have. @herd what do you think. Although could you check this patch applies to 2.22 ? Created attachment 147654 [details, diff]
control-center-2.22.0-more_apps.patch
This patch is for control-center-2.22, it shouldn't break anything, but I cannot be 100% sure because I still cannot update to gnome-2.22 as I run a stable system and other people need a stable gnome installation.
Quick question though (disclaimer, I haven't tried the patch, I've only read it) Why do you change the icon-name node from (for example) "firefox" to "firefox-icon" ? Other than that, I'm fine with most of the changes. Cool patch :) Because mozilla-firefox ebuild installs firefox icon as "firefox-icon.png" instead of "firefox.png" Indeed, you're right. Full ACK from me for this patch but I don't think there's a need to have Bon Echo in the list. People who use -bindist will probably know what they're doing. Bon Echo and Iceweasel lines are commented for now, maybe mozilla team should rename "firefox" executable to "bonecho" and "iceweasel" like debian does. I can try to open a bug report suggesting it, What do you think? Only one question: Do the options show up if the executable isn't installed? (I'm guessing not, since firefox doesn't show up for me and I don't have it it installed...) If that's the case, then full ACK from me too. No, it is not shown when executable is not found, the problem is that mozilla-firefox ebuild installs iceweasel and bonecho always as "firefox", causing all of them being always shown, this is why I have commented iceweasel-bonecho lines for now in attached patch I spoke with Raul (armin76) about it and he told me not to bother with bon echo and iceweasel. Let's just have "Firefox" :) (In reply to comment #10) > I spoke with Raul (armin76) about it and he told me not to bother with bon echo > and iceweasel. Let's just have "Firefox" :) > OK, then the patch can be applied as is because it has already commented bonecho/iceweasel sections (maybe in future...) commited to 2.22.2.1 without a bump. Thanks for the patch. |