Bug 214588 - media-plugins/audacious-plugins-1.4.4 does not compile scrobbler or last.fm plugin
Bug#: 214588 Product:  Gentoo Linux Version: unspecified Platform: x86
OS/Version: Linux Status: CLOSED Severity: minor Priority: P2
Resolution: UPSTREAM Assigned To: chainsaw@gentoo.org Reported By: wimmuskee@gmail.com
Component: Ebuilds
URL: 
Summary: media-plugins/audacious-plugins-1.4.4 does not compile scrobbler or last.fm plugin
Keywords:  
Status Whiteboard: 
Opened: 2008-03-24 20:02 0000
Description:   Opened: 2008-03-24 20:02 0000
The scrobbler plugin (for submitting songs to Last.fm and Gerpork) for
Audacious should be compiled in by default. 
It compiled only after emerging musicbrainz and curl (this solution was given
in the last.fm audacious group:
http://www.last.fm/group/Audacious/forum/36299/_/279820 )


Reproducible: Always

Steps to Reproduce:
1. emerge audacious-plugins (1.4.4) without having musicbrainz or curl
installed
2. restart audacious
3.

Actual Results:  
1. audacious-plugins emerged without any problems
2. The scrobbler plugin option was however not present in the plugin selection
screen of audacious

Expected Results:  
The scrobbler plugin should be available to select in the audacious
preferences.

------- Comment #1 From Tony Vroon 2008-07-22 14:15:12 0000 -------
With apologies for the excessive delay; the 1.5.1-r1 ebuild has a scrobbler
USE-flag that adds both curl & musicbrainz to the dependencies.

------- Comment #2 From Mikko Nisula 2008-08-02 12:20:34 0000 -------
As nenolod comments in the thread mentioned in the bug report, they don't
depend on musicbrainz anymore. Scrobbling works for me fine without it. So only
curl is necessary, please remove the musicbrainz dependency?

------- Comment #3 From Tony Vroon 2008-08-02 12:25:51 0000 -------
Disagreed, the Makefile still refers to it:
Makefile:LIBS += ${GTK_LIBS} ${GLIB_LIBS}  ${CURL_LIBS} ${MUSICBRAINZ_LIBS}
${MOWGLI_LIBS} -laudutil

If you can get this confirmed and removed upstream, I will remove the
dependency.

------- Comment #4 From Rafał Mużyło 2009-04-21 03:15:28 0000 -------
It's highly amusing to comment on this bug
several months after it's been closed, but:
- audacious plugins *ebuild* depends on musicbrainz,
but doesn't use slot dependencies, as it probably should,
if it would really depend on musicbrainz
- while it does have MUSICBRAINZ_LIBS in the Makefile,
it seems that nothing is actually setting that var,
in fact, 'ldd /usr/lib/audacious/General/scrobbler.so' gives:
        linux-gate.so.1 =>  (0xb7f3e000)
        libgtk-x11-2.0.so.0 => /usr/lib/libgtk-x11-2.0.so.0 (0xb7b60000)
        libgdk-x11-2.0.so.0 => /usr/lib/libgdk-x11-2.0.so.0 (0xb7ad3000)
        libgobject-2.0.so.0 => /usr/lib/libgobject-2.0.so.0 (0xb7a98000)
        libglib-2.0.so.0 => /usr/lib/libglib-2.0.so.0 (0xb79c9000)
        libcurl.so.4 => /usr/lib/libcurl.so.4 (0xb7985000)
        libmowgli.so.2 => /usr/lib/libmowgli.so.2 (0xb7975000)
        libpthread.so.0 => /lib/libpthread.so.0 (0xb795c000)
        libc.so.6 => /lib/libc.so.6 (0xb781c000)
        libXinerama.so.1 => /usr/lib/libXinerama.so.1 (0xb7818000)
        libXrandr.so.2 => /usr/lib/libXrandr.so.2 (0xb7810000)
        libXcursor.so.1 => /usr/lib/libXcursor.so.1 (0xb7806000)
        libgdk_pixbuf-2.0.so.0 => /usr/lib/libgdk_pixbuf-2.0.so.0 (0xb77ec000)
        libpangocairo-1.0.so.0 => /usr/lib/libpangocairo-1.0.so.0 (0xb77df000)
        libXcomposite.so.1 => /usr/lib/libXcomposite.so.1 (0xb77db000)
        libXdamage.so.1 => /usr/lib/libXdamage.so.1 (0xb77d7000)
        libXfixes.so.3 => /usr/lib/libXfixes.so.3 (0xb77d1000)
        libatk-1.0.so.0 => /usr/lib/libatk-1.0.so.0 (0xb77b5000)
        libcairo.so.2 => /usr/lib/libcairo.so.2 (0xb773f000)
        libpixman-1.so.0 => /usr/lib/libpixman-1.so.0 (0xb76fb000)
        libdirectfb-1.2.so.0 => /usr/lib/libdirectfb-1.2.so.0 (0xb768a000)
        libfusion-1.2.so.0 => /usr/lib/libfusion-1.2.so.0 (0xb7680000)
        libdirect-1.2.so.0 => /usr/lib/libdirect-1.2.so.0 (0xb766a000)
        libglitz-glx.so.1 => /usr/lib/libglitz-glx.so.1 (0xb7663000)
        libGL.so.1 => //usr//lib/opengl/xorg-x11/lib/libGL.so.1 (0xb75fe000)
        libXmu.so.6 => /usr/lib/libXmu.so.6 (0xb75e6000)
        libXt.so.6 => /usr/lib/libXt.so.6 (0xb7593000)
        libSM.so.6 => /usr/lib/libSM.so.6 (0xb758a000)
        libICE.so.6 => /usr/lib/libICE.so.6 (0xb7571000)
        libuuid.so.1 => /lib/libuuid.so.1 (0xb756c000)
        libXi.so.6 => /usr/lib/libXi.so.6 (0xb7561000)
        libXext.so.6 => /usr/lib/libXext.so.6 (0xb7552000)
        libglitz.so.1 => /usr/lib/libglitz.so.1 (0xb752b000)
        libpng12.so.0 => /usr/lib/libpng12.so.0 (0xb7506000)
        libxcb-render-util.so.0 => /usr/lib/libxcb-render-util.so.0
(0xb7501000)
        libxcb-render.so.0 => /usr/lib/libxcb-render.so.0 (0xb74f9000)
        libXrender.so.1 => /usr/lib/libXrender.so.1 (0xb74ee000)
        libX11.so.6 => /usr/lib/libX11.so.6 (0xb73d9000)
        libxcb.so.1 => /usr/lib/libxcb.so.1 (0xb73be000)
        libXau.so.6 => /usr/lib/libXau.so.6 (0xb73ba000)
        libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0xb73b4000)
        libgio-2.0.so.0 => /usr/lib/libgio-2.0.so.0 (0xb734d000)
        libpangoft2-1.0.so.0 => /usr/lib/libpangoft2-1.0.so.0 (0xb7323000)
        libpango-1.0.so.0 => /usr/lib/libpango-1.0.so.0 (0xb72e2000)
        libfontconfig.so.1 => /usr/lib/libfontconfig.so.1 (0xb72b5000)
        libfreetype.so.6 => /usr/lib/libfreetype.so.6 (0xb7234000)
        libz.so.1 => /lib/libz.so.1 (0xb7221000)
        libexpat.so.1 => /usr/lib/libexpat.so.1 (0xb71f9000)
        libgmodule-2.0.so.0 => /usr/lib/libgmodule-2.0.so.0 (0xb71f3000)
        libdl.so.2 => /lib/libdl.so.2 (0xb71ef000)
        libm.so.6 => /lib/libm.so.6 (0xb71ca000)
        libidn.so.11 => /usr/lib/libidn.so.11 (0xb7198000)
        libldap-2.3.so.0 => /usr/lib/libldap-2.3.so.0 (0xb715d000)
        liblber-2.3.so.0 => /usr/lib/liblber-2.3.so.0 (0xb714f000)
        libsasl2.so.2 => /usr/lib/libsasl2.so.2 (0xb7136000)
        libssl.so.0.9.8 => /usr/lib/libssl.so.0.9.8 (0xb70f1000)
        librt.so.1 => /lib/librt.so.1 (0xb70e8000)
        libgssapi.so.2 => /usr/lib/libgssapi.so.2 (0xb70bd000)
        libheimntlm.so.0 => /usr/lib/libheimntlm.so.0 (0xb70b6000)
        libkrb5.so.25 => /usr/lib/libkrb5.so.25 (0xb7050000)
        libsqlite3.so.0 => /usr/lib/libsqlite3.so.0 (0xb6fe4000)
        libhx509.so.4 => /usr/lib/libhx509.so.4 (0xb6fa7000)
        libcrypto.so.0.9.8 => /usr/lib/libcrypto.so.0.9.8 (0xb6e65000)
        libasn1.so.8 => /usr/lib/libasn1.so.8 (0xb6de9000)
        libwind.so.0 => /usr/lib/libwind.so.0 (0xb6dbf000)
        libcom_err.so.2 => /lib/libcom_err.so.2 (0xb6dbb000)
        libroken.so.18 => /usr/lib/libroken.so.18 (0xb6da7000)
        libcrypt.so.1 => /lib/libcrypt.so.1 (0xb6d75000)
        libresolv.so.2 => /lib/libresolv.so.2 (0xb6d62000)
        libgnutls.so.26 => /usr/lib/libgnutls.so.26 (0xb6cca000)
        libtasn1.so.3 => /usr/lib/libtasn1.so.3 (0xb6cb8000)
        libgcrypt.so.11 => /usr/lib/libgcrypt.so.11 (0xb6c46000)
        libgpg-error.so.0 => /usr/lib/libgpg-error.so.0 (0xb6c41000)
        /lib/ld-linux.so.2 (0xb7f3f000)
        libXxf86vm.so.1 => /usr/lib/libXxf86vm.so.1 (0xb6c3a000)
        libX11-xcb.so.1 => /usr/lib/libX11-xcb.so.1 (0xb6c37000)
        libxcb-glx.so.0 => /usr/lib/libxcb-glx.so.0 (0xb6c24000)
        libdrm.so.2 => /usr/lib/libdrm.so.2 (0xb6c19000)
so unless it dlopens that libs (unlikely), it does *not* depend on it.

------- Comment #5 From Rafał Mużyło 2009-04-21 03:17:10 0000 -------
Of course, I'm talking about 1.5.1 version.

------- Comment #6 From Rafał Mużyło 2009-05-10 21:21:37 0000 -------
I don't want to nag, but will somebody at least
examine my claim ?
I've rebuilt audacious plugins without musicbrainz
and scrobbler plugin built just fine.

------- Comment #7 From Tony Vroon 2009-05-10 21:31:49 0000 -------
Report your bug upstream at http://www.atheme.org/issues/
As long as the Makefile refers to musicbrainz, I will continue to have the
ebuild depend on it. You are reopening old bugs, which is unhelpful. Please
cease this activity.

Report your bug where it belongs, upstream.

------- Comment #8 From Rafał Mużyło 2009-05-10 22:25:19 0000 -------
In the initial report, the link leads to a following comment by nenolod:
"we don't depend on musicbrainz anymore..."
This block in configure.ac is the only check for scrobbler deps:
scrobbler="yes"
have_lastfm="no"

dnl libcurl check

my_cv_curl_vers=NONE
dnl check is the plain-text version of the required version
check="7.9.7"
dnl check_hex must be UPPERCASE if any hex letters are present
check_hex="070907"

PKG_CHECK_MODULES(CURL, [libcurl >= 7.9.7], [], [scrobbler="no"])
AC_SUBST(CURL_CFLAGS)
AC_SUBST(CURL_LIBS)

if test "x$scrobbler" = "xyes"; then
        GENERAL_PLUGINS="$GENERAL_PLUGINS scrobbler"
        TRANSPORT_PLUGINS="$TRANSPORT_PLUGINS lastfm"
        have_lastfm="yes"
fi

I'm nearly sure, that this means, that the reference in Makefile
is a simple leftover from the time, when they did depend on musicbrainz.

And it's not like upstream has anything to fix (configure doesn't
check for musicbrainz, Makefile is janitorial-only, so no point to bother
while they're working intensively on 2.0). After all, why should they fix
anything now, if nenolod's comment dates 25 May 2007 ?

------- Comment #9 From Rafał Mużyło 2009-05-10 22:27:33 0000 -------
And for completeness sake:
http://redmine.atheme.org/repositories/diff/audacious-plugins?rev=45

------- Comment #10 From Rafał Mużyło 2009-05-10 22:29:43 0000 -------
And as you may see, that was done before 1.2.2 release.

------- Comment #11 From Tony Vroon 2009-05-10 22:41:32 0000 -------
I don't see an upstream bug report. As I said, cease reopening old bugs,
whether or not they seem relevant.