Bug 212008 - media-sound/audacity-1.3.4 support for wxGTK-2.8
Bug#: 212008 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: proaudio@gentoo.org Reported By: moloh@gentoo.org
Component: Ebuilds
URL:  http://audacity.sourceforge.net/download/features-1.3-a
Summary: media-sound/audacity-1.3.4 support for wxGTK-2.8
Keywords:  
Status Whiteboard: 
Opened: 2008-03-01 19:22 0000
Description:   Opened: 2008-03-01 19:22 0000
One of the features, as described in link, of 1.3.3 version was support for
building with wxWidgets-2.8. Would that be possible to add this support to the
ebuild?

Reproducible: Always

------- Comment #1 From Alexis Ballier 2008-03-01 19:42:55 0000 -------
(In reply to comment #0)
> One of the features, as described in link, of 1.3.3 version was support for
> building with wxWidgets-2.8. Would that be possible to add this support to the
> ebuild?

Could be an idea but last time I asked, Ryan answered me that it was not
possible to specify that it would work with 2.6 and 2.8, we had to stick to one
single version.
@wxwidgets: any insight on how to make it grok wx 2.8 ?
would it be safe to switch now or better to wait for a new audacity release /
rev bump that we will stick only to 2.8 ?
(as a side note wx 2.8 was not in the tree at the time of adding 1.3.4 and I
wanted to switch entirely to 2.8 for next audacity release)

Anyway, I was afraid that wx 2.8 could hold stabilisation of audacity in case
of real problem but it seems its going its way to stable.

------- Comment #2 From Mart Raudsepp 2008-03-02 00:14:26 0000 -------
Please feel free to maintain separate revisions - one for wxGTK-2.6 and another
for wxGTK-2.8. The point is that you shouldn't have one revision try to work
with either.
Of course if it works great with wxGTK-2.8 there is no reason to support 2.6
anymore (besides amd64 and sh not having a stable 2.8 yet, but audacity
stabling could be a good push for that to be finalized)

------- Comment #3 From Alexis Ballier 2008-03-04 19:16:46 0000 -------
-r3 now uses wxgtk 2.8

------- Comment #4 From Michal Kurgan (RETIRED) 2008-03-04 22:30:04 0000 -------
Thanks for quick fix.

------- Comment #5 From David Watzke 2008-03-04 23:00:54 0000 -------
It fails here:

checking for wx-config... /usr/lib64/wx/config/gtk2-unicode-release-2.8

  Warning: No config found to match:
/usr/lib64/wx/config/gtk2-unicode-release-2.8 --unicode=no --version
           in /usr/lib64/wx/config
  If you require this configuration, please install the desired
  library build.  If this is part of an automated configuration
  test and no other errors occur, you may safely ignore it.
  You may use wx-config --list to see all configs available in
  the default prefix.

I don't get this because I have unicode USE-flag enabled for audacity...

------- Comment #6 From Ryan Hill 2008-03-05 00:39:13 0000 -------
erm, there is no unicode USE flag in the 2.8-using ebuild.

------- Comment #7 From David Watzke 2008-03-05 01:02:14 0000 -------
(In reply to comment #6)
> erm, there is no unicode USE flag in the 2.8-using ebuild.

heh, true... but the strange thing is this in this 2.8-using ebuild:

need-wxwidgets unicode

if I'm not mistaken, this means it passes with the unicode version of wxgtk
(with which it fails) and fails with the non-unicode one (with which it would
work, I guess)

------- Comment #8 From Ryan Hill 2008-03-05 01:08:41 0000 -------
the thing is there is no non-unicode wxpython-2.8 in Gentoo.  starting in 2.8
it's unicode-only so i don't know why it's looking for
/usr/lib64/wx/config/gtk2-unicode-release-2.8 --unicode=no

  what does /usr/lib64/wx/config/gtk2-unicode-release-2.8 --list

say?

------- Comment #9 From David Watzke 2008-03-05 01:14:52 0000 -------
it says:

    Default config is gtk2-unicode-release-2.8

  Default config will be used for output

------- Comment #10 From Ryan Hill 2008-03-05 01:26:23 0000 -------
that's really weird.

configure does this:

  wx_version=`${WX_CONFIG} $static_preference $unicode_preference
$debug_preference $wx_preference --version`

$unicode_preference is set with --enable-unicode..

  # Check whether --enable-unicode was given.
  if test "${enable_unicode+set}" = set; then
    enableval=$enable_unicode; unicode_preference="--unicode=$enableval"
  else
    unicode_preference=""
  fi

i'm not sure what's going wrong here.

------- Comment #11 From Ryan Hill 2008-03-05 01:30:02 0000 -------
oh, got it.

revision 1.2
date: 2008-03-04 15:03:05 -0600;  author: aballier;  state: Exp;  lines: +2 -2;
 commitid: 7e1847cdb9084567;
tss I fail, forgot one occurence of unicode useflag... as wx 2.8 forces unicode
we force it here too
(Portage version: 2.1.4.4)

you must have a copy of the ebuild before this fix.  please emerge --sync and
it should work.

------- Comment #12 From David Watzke 2008-03-05 01:40:20 0000 -------
yeah, this is it... I must have synced just a few minutes before this commit.
thx